cal/paper-dynasty-card-creation
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Replace wildcard import from db_calls_card_creation #13

New Issue
Closed
opened 2026-02-20 06:53:11 +00:00 by cal · 1 comment
cal commented 2026-02-20 06:53:11 +00:00
Owner
Copy Link

creation_helpers.py:15 — from db_calls_card_creation import *. Imports all Peewee ORM model classes and transitive from peewee import * into namespace. Causes namespace pollution and masks NameErrors.

Priority: medium | Labels: tech-debt

`creation_helpers.py:15` — `from db_calls_card_creation import *`. Imports all Peewee ORM model classes and transitive `from peewee import *` into namespace. Causes namespace pollution and masks NameErrors. **Priority**: medium | **Labels**: tech-debt
Claude added the
ai-working
 label 2026-03-20 23:31:14 +00:00
Claude removed the
ai-working
 label 2026-03-20 23:32:51 +00:00
Claude commented 2026-03-20 23:32:59 +00:00
Collaborator
Copy Link

Opened PR #34 to fix this.

Replaced from db_calls_card_creation import * with from db_calls_card_creation import PitcherData — the only symbol from that module actually used in creation_helpers.py. This eliminates the transitive from peewee import * namespace pollution.

Opened PR #34 to fix this. Replaced `from db_calls_card_creation import *` with `from db_calls_card_creation import PitcherData` — the only symbol from that module actually used in `creation_helpers.py`. This eliminates the transitive `from peewee import *` namespace pollution.
Claude added the
ai-pr-opened
 label 2026-03-20 23:33:02 +00:00
cal closed this issue 2026-03-23 12:37:31 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-merged

PR merged by AI ops agent

  
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-working
No Label
ai-merged
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-card-creation#13
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?