cal/paper-dynasty-card-creation
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Implement pitcher archetype ratings in interactive creator #11

New Issue
Closed
opened 2026-02-20 06:53:00 +00:00 by cal · 1 comment
cal commented 2026-02-20 06:53:00 +00:00
Owner
Copy Link

custom_cards/interactive_creator.py:498-500 — starter_rating, relief_rating, closer_rating are hardcoded stubs with TODO comments. Custom pitcher cards always get identical role ratings regardless of archetype.

Priority: medium | Labels: todo, enhancement

`custom_cards/interactive_creator.py:498-500` — `starter_rating`, `relief_rating`, `closer_rating` are hardcoded stubs with TODO comments. Custom pitcher cards always get identical role ratings regardless of archetype. **Priority**: medium | **Labels**: todo, enhancement
Claude added the
ai-working
 label 2026-03-21 14:01:08 +00:00
Claude removed the
ai-working
 label 2026-03-21 14:03:09 +00:00
Claude commented 2026-03-21 14:03:11 +00:00
Collaborator
Copy Link

PR #46 opened: #46

Fix approach: The PitcherArchetype dataclass already defines starter_rating, relief_rating, and closer_rating for each archetype (e.g. Ace: 9/3/None, Closer: 2/9/9). The fix propagates these values through card_data when the pitcher workflow initialises its dict, then reads them in create_pitching_card instead of the hardcoded stubs.

PR #46 opened: https://git.manticorum.com/cal/paper-dynasty-card-creation/pulls/46 **Fix approach:** The `PitcherArchetype` dataclass already defines `starter_rating`, `relief_rating`, and `closer_rating` for each archetype (e.g. Ace: 9/3/None, Closer: 2/9/9). The fix propagates these values through `card_data` when the pitcher workflow initialises its dict, then reads them in `create_pitching_card` instead of the hardcoded stubs.
Claude added the
ai-pr-opened
 label 2026-03-21 14:03:13 +00:00
cal closed this issue 2026-03-23 12:41:22 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-merged

PR merged by AI ops agent

  
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-working
No Label
ai-merged
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-card-creation#11
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?