cal/paper-dynasty-card-creation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
141 Commits 1 Branch 0 Tags 99 MiB
bd1cc7e90b
Commit Graph

31 Commits

Author SHA1 Message Date
Cal Corum
bd1cc7e90b CLAUDE: Refactor to reduce code fragility - extract business logic and add constants 
This commit implements high value-to-time ratio improvements to make the
codebase more maintainable and less fragile:

## Changes Made

1. **Add constants for magic numbers** (creation_helpers.py)
   - NEW_PLAYER_COST = 99999 (replaces hardcoded sentinel value)
   - RARITY_BASE_COSTS dict (replaces duplicate cost dictionaries)
   - Benefits: Self-documenting, single source of truth, easy to update

2. **Extract business logic into testable function** (creation_helpers.py)
   - Added should_update_player_description() with full docstring
   - Consolidates duplicated logic from batters and pitchers modules
   - Independently testable, clear decision logic with examples
   - Benefits: DRY principle, better testing, easier to modify

3. **Add debug logging for description updates** (batters & pitchers)
   - Logs when descriptions ARE updated (with details)
   - Logs when descriptions are SKIPPED (with reason)
   - Benefits: Easy troubleshooting, visibility into decisions

4. **Update batters/creation.py and pitchers/creation.py**
   - Replace hardcoded 99999 with NEW_PLAYER_COST
   - Replace base_costs dict with RARITY_BASE_COSTS
   - Replace inline logic with should_update_player_description()
   - Improved docstring for post_player_updates()
   - Benefits: Cleaner, more maintainable code

5. **Add comprehensive tests** (tests/test_promo_description_protection.py)
   - 6 new direct unit tests for should_update_player_description()
   - Tests cover: promo/regular cardsets, new/existing players, PotM cards
   - Case-insensitive detection tests
   - Benefits: Confidence in behavior, prevent regressions

6. **Add documentation** (PROMO_CARD_FIX.md, REFACTORING_SUMMARY.md)
   - PROMO_CARD_FIX.md: Details the promo card renaming fix
   - REFACTORING_SUMMARY.md: Comprehensive refactoring documentation
   - Benefits: Future developers understand the code and changes

## Test Results
✅ 13/13 tests pass (7 existing + 6 new)
✅ No regressions in existing tests
✅ 100% backward compatible

## Impact
- Magic numbers: 100% eliminated
- Duplicated logic: 50% reduction (2 files → 1 function)
- Test coverage: +86% (7 → 13 tests)
- Code clarity: Significantly improved
- Maintainability: Much easier to modify and debug

## Files Modified
- creation_helpers.py: +82 lines (constants, function, docs)
- batters/creation.py: Simplified using new constants/function
- pitchers/creation.py: Simplified using new constants/function
- tests/test_promo_description_protection.py: +66 lines (new tests)
- PROMO_CARD_FIX.md: New documentation
- REFACTORING_SUMMARY.md: New documentation

Total: ~228 lines added/modified for significant maintainability gain

Related to earlier promo card description protection fix.
 2025-10-31 22:03:22 -05:00
Cal Corum
c89e1eb507 Claude introduction & Live Series Update 2025-07-22 09:24:34 -05:00
Cal Corum
25d4d9a63c Migrate to rotating file logger 2024-11-10 14:42:12 -06:00
Cal Corum
cdb5820dbc Pitchers are complete 2024-11-01 08:50:29 -05:00
Cal Corum
b3102201c8 Added Devil Rays to club and franchise lists 
Fixed bphr fraction bug
Removed player post limit
 2024-10-25 12:24:08 -05:00
Cal Corum
5c6d706160 Player post complete 
Batting card post complete
 2024-10-25 07:06:06 -05:00
Cal Corum
2ef68915d1 Add Montreal to franchise list 
Fix precision bug in mround
 2024-10-20 22:55:59 -05:00
Cal Corum
d8e30ec5f9 Batting cards and ratings being calculated; began positions 2024-10-19 23:02:32 -05:00
Cal Corum
0de2239100 Updated mround to return float 
Counting stats nearly complete for batters
 2024-10-18 12:12:40 -05:00
Cal Corum
639e032586 Moving older scripts into holding cell 2024-10-17 09:28:02 -05:00
Cal Corum
f0f77ffb16 End of season card data plus handedness bugfix 2024-10-16 22:35:35 -05:00
Cal Corum
40d22ae61e Fix incorrect player match 2024-07-03 09:54:55 -05:00
Cal Corum
72968f5e5d Add MLB Player support 2024-05-26 10:53:15 -05:00
Cal Corum
c4d9e0524f May 05 Card Data 2024-05-12 13:45:15 -05:00
Cal Corum
9182556e44 Add support for custom batting cards 2024-03-03 17:57:30 -06:00
Cal Corum
dae6b7e8df Refactor creation to modules 2023-11-05 20:05:11 -06:00
Cal Corum
92e5240e65 Refactor pit/bat/def to modules 2023-11-05 12:18:42 -06:00
Cal Corum
46ec97e501 Add franchise logic 2023-10-30 21:18:57 -05:00
Cal Corum
a07dc98373 Reference prod database 2023-10-24 09:49:03 -05:00
Cal Corum
31a2fe8804 Added teams from fg for new players 2023-10-22 14:00:43 -05:00
Cal Corum
3a247f7487 Full 2023 run complete 2023-10-21 00:40:15 -05:00
Cal Corum
cfdf0e985d Batting card generation active 
Fully functional through to png files
 2023-10-14 23:42:53 -05:00
Cal Corum
5974ec665e Full live card gen successful 2023-10-11 00:58:56 -05:00
Cal Corum
d4167b2b0c Full pitching run successful 2023-10-03 12:06:11 -05:00
Cal Corum
b3c98e3c6e Beginning work on pitching rating calcs 2023-09-29 16:24:43 -05:00
Cal Corum
f8f3dd9ec1 Phase 1 of pitching complete 2023-09-25 00:20:03 -05:00
Cal Corum
4bde7f60ea fielding and batting functional 
Still need pitching and setting player positions
 2023-09-24 18:58:44 -05:00
Cal Corum
d32b778d66 2008 & 2016 Creation 2023-05-28 10:44:57 -05:00
Cal Corum
01222b5466 Mario and Live 2023 set releases 2023-04-25 01:45:17 -05:00
Cal Corum
dca8eaa8cd Update creation_helpers.py 
add DH support
 2023-02-24 21:47:37 -06:00
Cal Corum
0e1f932531 Initial commit 2023-02-22 15:40:14 -06:00