2926664d2d
Eliminates redundant constants.py file by moving all constants to config.py.
All constants (except baseball positions) are now accessible via get_config().
Changes:
- config.py: Added baseball position sets as module-level constants
* PITCHER_POSITIONS, POSITION_FIELDERS, ALL_POSITIONS remain static
* All other constants now accessed via BotConfig instance
- constants.py: Deleted (redundant with config.py)
- Updated 27 files to use get_config() instead of constants module:
* Commands: admin, help, league (3), players, profile, teams (3),
transactions (3), utilities, voice
* Services: league, player, team, trade_builder, transaction_builder
* Utils: autocomplete, team_utils
* Views: embeds
* Tests: test_constants, test_services (3 files)
* Examples: enhanced_player, migration_example
- tests/test_constants.py: Rewritten to test config values
* All 14 tests pass
* Now validates BotConfig defaults instead of constants module
Import Changes:
- Old: `from constants import SBA_CURRENT_SEASON`
- New: `from config import get_config` → `get_config().sba_current_season`
- Positions: `from config import PITCHER_POSITIONS, ALL_POSITIONS`
Benefits:
- Single source of truth (config.py only)
- Cleaner architecture - no redundant wrapper
- All constants configurable via environment variables
- Reduced maintenance overhead
- Type safety with Pydantic validation
All configuration tests pass. Core refactoring complete.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
100 lines
2.6 KiB
Python
100 lines
2.6 KiB
Python
"""
|
|
Configuration management for Discord Bot v2.0
|
|
"""
|
|
from pydantic_settings import BaseSettings, SettingsConfigDict
|
|
|
|
# Baseball position constants (static, not configurable)
|
|
PITCHER_POSITIONS = {"SP", "RP", "P"}
|
|
POSITION_FIELDERS = {"C", "1B", "2B", "3B", "SS", "LF", "CF", "RF", "OF", "DH"}
|
|
ALL_POSITIONS = PITCHER_POSITIONS | POSITION_FIELDERS
|
|
|
|
|
|
class BotConfig(BaseSettings):
|
|
"""Application configuration with environment variable support."""
|
|
|
|
# Discord settings
|
|
bot_token: str
|
|
guild_id: int
|
|
|
|
# Database API settings
|
|
api_token: str
|
|
db_url: str
|
|
|
|
# Discord Limits
|
|
discord_embed_limit: int = 6000
|
|
discord_field_value_limit: int = 1024
|
|
discord_embed_description_limit: int = 4096
|
|
|
|
# League settings
|
|
sba_season: int = 12
|
|
pd_season: int = 9
|
|
fa_lock_week: int = 14
|
|
sba_color: str = "a6ce39"
|
|
weeks_per_season: int = 18
|
|
games_per_week: int = 4
|
|
modern_stats_start_season: int = 8
|
|
|
|
# Current Season Constants
|
|
sba_current_season: int = 12
|
|
pd_current_season: int = 9
|
|
|
|
# API Constants
|
|
api_version: str = "v3"
|
|
default_timeout: int = 10
|
|
max_retries: int = 3
|
|
|
|
# Draft Constants
|
|
default_pick_minutes: int = 10
|
|
draft_rounds: int = 25
|
|
|
|
# Special Team IDs
|
|
free_agent_team_id: int = 498
|
|
|
|
# Role Names
|
|
help_editor_role_name: str = "Help Editor"
|
|
sba_players_role_name: str = "Season 12 Players"
|
|
|
|
# Channel Names
|
|
sba_network_news_channel: str = "sba-network-news"
|
|
|
|
# Base URLs
|
|
sba_base_url: str = "https://sba.manticorum.com"
|
|
|
|
# Application settings
|
|
log_level: str = "INFO"
|
|
environment: str = "development"
|
|
testing: bool = False
|
|
|
|
# Google Sheets settings
|
|
sheets_credentials_path: str = "/app/data/major-domo-service-creds.json"
|
|
|
|
# Optional Redis caching settings
|
|
redis_url: str = "" # Empty string means no Redis caching
|
|
redis_cache_ttl: int = 300 # 5 minutes default TTL
|
|
|
|
model_config = SettingsConfigDict(
|
|
env_file=".env",
|
|
case_sensitive=False,
|
|
extra="ignore" # Ignore extra environment variables
|
|
)
|
|
|
|
@property
|
|
def is_development(self) -> bool:
|
|
"""Check if running in development mode."""
|
|
return self.environment.lower() == "development"
|
|
|
|
@property
|
|
def is_testing(self) -> bool:
|
|
"""Check if running in test mode."""
|
|
return self.testing
|
|
|
|
|
|
# Global configuration instance - lazily initialized to avoid import-time errors
|
|
_config = None
|
|
|
|
def get_config() -> BotConfig:
|
|
"""Get the global configuration instance."""
|
|
global _config
|
|
if _config is None:
|
|
_config = BotConfig() # type: ignore
|
|
return _config |