0c6f7c8ffe
This commit addresses critical bugs in the injury command system and establishes best practices for Discord command groups. ## Critical Fixes ### 1. GroupCog → app_commands.Group Migration - **Problem**: `commands.GroupCog` has a duplicate interaction processing bug causing "404 Unknown interaction" errors when deferring responses - **Root Cause**: GroupCog triggers command handler twice, consuming the interaction token before the second execution can respond - **Solution**: Migrated InjuryCog to InjuryGroup using `app_commands.Group` pattern (same as ChartManageGroup and ChartCategoryGroup) - **Result**: Reliable command execution, no more 404 errors ### 2. GiphyService GIF URL Fix - **Problem**: Giphy service returned web page URLs (https://giphy.com/gifs/...) instead of direct image URLs, preventing Discord embed display - **Root Cause**: Code accessed `data.url` instead of `data.images.original.url` - **Solution**: Updated both `get_disappointment_gif()` and `get_gif()` methods to use correct API response path for embeddable GIF URLs - **Result**: GIFs now display correctly in Discord embeds ## Documentation ### Command Groups Best Practices (commands/README.md) Added comprehensive section documenting: - **Critical Warning**: Never use `commands.GroupCog` - use `app_commands.Group` - **Technical Explanation**: Why GroupCog fails (duplicate execution bug) - **Migration Guide**: Step-by-step conversion from GroupCog to Group - **Comparison Table**: Key differences between the two approaches - **Working Examples**: References to ChartManageGroup, InjuryGroup patterns ## Architecture Changes ### Injury Commands (`commands/injuries/`) - Converted from `commands.GroupCog` to `app_commands.Group` - Registration via `bot.tree.add_command()` instead of `bot.add_cog()` - Removed workarounds for GroupCog duplicate interaction issues - Clean defer/response pattern with `@logged_command` decorator ### GiphyService (`services/giphy_service.py`) - Centralized from `commands/soak/giphy_service.py` - Now returns direct GIF image URLs for Discord embeds - Maintains Trump GIF filtering (legacy behavior) - Added gif_url to log output for debugging ### Configuration (`config.py`) - Added `giphy_api_key` and `giphy_translate_url` settings - Environment variable support via `GIPHY_API_KEY` - Default values provided for out-of-box functionality ## Files Changed - commands/injuries/: New InjuryGroup with app_commands.Group pattern - services/giphy_service.py: Centralized service with GIF URL fix - commands/soak/giphy_service.py: Backwards compatibility wrapper - commands/README.md: Command groups best practices documentation - config.py: Giphy configuration settings - services/__init__.py: GiphyService exports 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
35 lines
871 B
Python
35 lines
871 B
Python
"""
|
|
Injury commands package
|
|
|
|
Provides commands for managing player injuries:
|
|
- /injury roll - Roll for injury using player's injury rating
|
|
- /injury set-new - Set a new injury for a player
|
|
- /injury clear - Clear a player's injury
|
|
"""
|
|
from discord.ext import commands
|
|
from .management import setup
|
|
|
|
__all__ = ['setup_injuries']
|
|
|
|
|
|
async def setup_injuries(bot: commands.Bot) -> tuple[int, int, list[str]]:
|
|
"""
|
|
Setup function for loading injury commands.
|
|
|
|
Returns:
|
|
Tuple of (successful_count, failed_count, failed_module_names)
|
|
"""
|
|
successful = 0
|
|
failed = 0
|
|
failed_modules = []
|
|
|
|
try:
|
|
await setup(bot)
|
|
successful += 1
|
|
except Exception as e:
|
|
bot.logger.error(f"Failed to load InjuryGroup: {e}")
|
|
failed += 1
|
|
failed_modules.append('InjuryGroup')
|
|
|
|
return successful, failed, failed_modules
|