perf: parallelize independent API calls (team lookups, injury cmds, trade validation) #90

New Issue

cal · 2026-03-20T13:17:16Z

cal commented

2026-03-20 13:17:16 +00:00

Problem

Many commands make 2–4 independent API calls sequentially when they could use asyncio.gather().

Team lookups (away + home)

commands/gameplay/scorebug.py lines 77–81, 184–187
commands/league/submit_scorecard.py lines 110–115
tasks/live_scorebug_tracker.py lines 120–126 (inside a per-scorecard loop — compounds)

Pattern:

away_team = await team_service.get_team(away_team_id)
home_team = await team_service.get_team(home_team_id)

Injury commands

commands/injuries/management.py:
- injury_roll lines 117–125: get_current_state() + search_players() independent
- injury_set_new lines 533–548: multiple independent service calls
- injury_clear lines 720–741: same pattern

Trade validation

services/trade_builder.py lines 526–536: per-participant roster validation is sequential but independent per team

Fix

Replace sequential awaits with asyncio.gather() in each case. Example:

away_team, home_team = await asyncio.gather(
    team_service.get_team(away_team_id),
    team_service.get_team(home_team_id),
)

Impact

MEDIUM — Each location saves 50–200ms. Scorebug tracker compounds across 5+ games per update cycle.

## Problem Many commands make 2–4 independent API calls sequentially when they could use `asyncio.gather()`. ### Team lookups (away + home) - `commands/gameplay/scorebug.py` lines 77–81, 184–187 - `commands/league/submit_scorecard.py` lines 110–115 - `tasks/live_scorebug_tracker.py` lines 120–126 (inside a per-scorecard loop — compounds) Pattern: ```python away_team = await team_service.get_team(away_team_id) home_team = await team_service.get_team(home_team_id) ``` ### Injury commands - `commands/injuries/management.py`: - `injury_roll` lines 117–125: `get_current_state()` + `search_players()` independent - `injury_set_new` lines 533–548: multiple independent service calls - `injury_clear` lines 720–741: same pattern ### Trade validation - `services/trade_builder.py` lines 526–536: per-participant roster validation is sequential but independent per team ## Fix Replace sequential awaits with `asyncio.gather()` in each case. Example: ```python away_team, home_team = await asyncio.gather( team_service.get_team(away_team_id), team_service.get_team(home_team_id), ) ``` ## Impact **MEDIUM** — Each location saves 50–200ms. Scorebug tracker compounds across 5+ games per update cycle.

cal added the

ai-working

label 2026-03-20 13:18:36 +00:00

cal removed the

ai-working

label 2026-03-20 13:21:32 +00:00

Claude added the

ai-working

label 2026-03-20 16:01:11 +00:00

Claude added the

status/in-progress

label 2026-03-20 16:04:40 +00:00

cal referenced this issue from a commit

2026-03-20 16:07:58 +00:00

perf: parallelize independent API calls (#90)

Claude referenced a pull request that will close this issue

2026-03-20 16:08:13 +00:00

perf: parallelize independent API calls (#90) #106

Claude added the

status/pr-open

label 2026-03-20 16:08:41 +00:00

Claude commented

2026-03-20 16:08:46 +00:00

PR #106 opened: #106

Replaced all sequential awaits with asyncio.gather() across 5 files:

scorebug.py: Both commands now fetch away/home teams in parallel (uses asyncio.sleep(0) as a None-returning coroutine for optional IDs)
submit_scorecard.py: Parallel team-by-abbreviation lookups
live_scorebug_tracker.py: Parallel team lookups inside the 3-minute update loop
injuries/management.py: Parallel get_current_state() + search_players() in all 3 injury commands
trade_builder.py: All participant roster validations gathered in parallel

Also fixed missing await on scorecard_tracker async methods in scorebug.py and live_scorebug_tracker.py (auto-corrected by linter — those methods were made async in a prior working-tree change).

PR #106 opened: https://git.manticorum.com/cal/major-domo-v2/pulls/106 Replaced all sequential awaits with `asyncio.gather()` across 5 files: - **scorebug.py**: Both commands now fetch away/home teams in parallel (uses `asyncio.sleep(0)` as a None-returning coroutine for optional IDs) - **submit_scorecard.py**: Parallel team-by-abbreviation lookups - **live_scorebug_tracker.py**: Parallel team lookups inside the 3-minute update loop - **injuries/management.py**: Parallel `get_current_state()` + `search_players()` in all 3 injury commands - **trade_builder.py**: All participant roster validations gathered in parallel Also fixed missing `await` on `scorecard_tracker` async methods in `scorebug.py` and `live_scorebug_tracker.py` (auto-corrected by linter — those methods were made async in a prior working-tree change).

Claude added

ai-pr-opened

and removed

ai-working

labels 2026-03-20 16:08:53 +00:00

cal referenced this issue from a commit

2026-03-20 17:48:16 +00:00

perf: parallelize independent API calls (#90)

cal closed this issue

2026-03-20 17:48:29 +00:00

cal referenced this issue from a commit

2026-03-20 17:48:30 +00:00