fix: trailing slash on all collection POST calls #75

cal · 2026-03-10T00:35:06Z

cal commented

2026-03-10 00:35:06 +00:00

Summary

Reverts universal trailing slash in _build_url (broke custom commands with 401)
Adds trailing slashes to ALL client.post() calls targeting collection endpoints
Covers: play_service, decision_service, base_service.create(), transaction_service, injury_service, draft_list_service (5 call sites)
Path-segment POSTs (games/wipe/{id}, custom_commands/creators, standings/s{season}/recalculate) correctly left without trailing slash

Context

aiohttp follows 307 redirects but converts POST→GET, silently dropping the request body. The database API now standardizes all collection POST routes on '/' (see cal/major-domo-database PR). This PR ensures the bot always POSTs with matching trailing slashes.

Companion PR: cal/major-domo-database (fix/standardize-post-trailing-slashes)

Test plan

930 tests pass, 3 skipped
All client.post() calls audited for correct trailing slash usage
Cross-repo URL alignment verified by code review
Non-POST methods (GET/PUT/PATCH/DELETE) unaffected

🤖 Generated with Claude Code

## Summary - Reverts universal trailing slash in `_build_url` (broke custom commands with 401) - Adds trailing slashes to ALL `client.post()` calls targeting collection endpoints - Covers: `play_service`, `decision_service`, `base_service.create()`, `transaction_service`, `injury_service`, `draft_list_service` (5 call sites) - Path-segment POSTs (`games/wipe/{id}`, `custom_commands/creators`, `standings/s{season}/recalculate`) correctly left without trailing slash ## Context aiohttp follows 307 redirects but converts POST→GET, silently dropping the request body. The database API now standardizes all collection POST routes on `'/'` (see cal/major-domo-database PR). This PR ensures the bot always POSTs with matching trailing slashes. Companion PR: cal/major-domo-database (fix/standardize-post-trailing-slashes) ## Test plan - [x] 930 tests pass, 3 skipped - [x] All `client.post()` calls audited for correct trailing slash usage - [x] Cross-repo URL alignment verified by code review - [x] Non-POST methods (GET/PUT/PATCH/DELETE) unaffected 🤖 Generated with [Claude Code](https://claude.com/claude-code)

cal added 1 commit 2026-03-10 00:35:07 +00:00

fix: add trailing slashes to all collection POST calls

Build Docker Image / build (pull_request) Successful in 1m16s

Details

ba55ed3109

Ensures all client.post() calls to collection endpoints include
trailing slashes, matching the standardized database API routes.
Covers BaseService.create(), TransactionService, InjuryService,
and DraftListService POST calls.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

cal merged commit 9ba0713887 into main

2026-03-10 00:42:17 +00:00

cal deleted branch fix/trailing-slash-307-redirect

2026-03-10 00:42:18 +00:00

cal referenced this issue from a commit

2026-03-10 00:42:19 +00:00

Merge pull request 'fix: trailing slash on all collection POST calls' (#75) from fix/trailing-slash-307-redirect into main

cal referenced this pull request

2026-03-10 05:28:07 +00:00

chore: pin all Python dependency versions in requirements.txt #76

Sign in to join this conversation.

No reviewers