Implement test_validate_transaction_exception_handling #35

New Issue

cal · 2026-02-20T06:50:32Z

cal commented

2026-02-20 06:50:32 +00:00

Description

tests/test_services_transaction.py:238-242 — Skipped with reason="Exception handling test needs refactoring for new patterns" and body is just pass. Exception handling in transaction validation is a critical code path with no coverage.

File Locations

tests/test_services_transaction.py:238-242

Labels

tech-debt, todo

Priority

medium

## Description `tests/test_services_transaction.py:238-242` — Skipped with `reason="Exception handling test needs refactoring for new patterns"` and body is just `pass`. Exception handling in transaction validation is a critical code path with no coverage. ## File Locations - `tests/test_services_transaction.py:238-242` ## Labels tech-debt, todo ## Priority medium

cal added the

ai-working

label 2026-03-05 08:00:59 +00:00

cal referenced this issue from a commit

2026-03-05 08:04:40 +00:00

test: implement test_validate_transaction_exception_handling (#35)

cal referenced this issue

2026-03-05 08:04:51 +00:00

test: implement test_validate_transaction_exception_handling (#35) #67

cal commented

2026-03-05 08:04:58 +00:00

Implemented in PR #67: #67

Removed the @pytest.mark.skip and implemented the test by patching RosterValidation in the transaction_service module to raise RuntimeError on its first call. This triggers the except Exception clause at transaction_service.py:187-192, which returns a failed RosterValidation(is_legal=False, errors=["Validation error: ..."]) instead of propagating the exception. All 20 tests in the file now pass.

Implemented in PR #67: https://git.manticorum.com/cal/major-domo-v2/pulls/67 Removed the `@pytest.mark.skip` and implemented the test by patching `RosterValidation` in the `transaction_service` module to raise `RuntimeError` on its first call. This triggers the `except Exception` clause at `transaction_service.py:187-192`, which returns a failed `RosterValidation(is_legal=False, errors=["Validation error: ..."])` instead of propagating the exception. All 20 tests in the file now pass.

cal added

ai-pr-opened

and removed

ai-working

labels 2026-03-05 08:05:14 +00:00

cal referenced this issue from a commit

2026-03-07 03:32:26 +00:00

Merge pull request 'test: implement test_validate_transaction_exception_handling (#35)' (#67) from ai/major-domo-v2#35 into next-release

cal closed this issue

2026-03-10 18:26:36 +00:00

Sign in to join this conversation.