Replace create_item_in_table placeholder with proper table-specific endpoint logic #30

New Issue

cal · 2026-02-20T06:50:03Z

cal commented

2026-02-20 06:50:03 +00:00

Description

services/base_service.py:510-531 — Contains comment: "This is a placeholder - real implementation would need table-specific endpoints". Blindly POSTs to whatever table_name is passed. Used by custom_commands_service for creating creator records.

File Locations

services/base_service.py:510-531

Labels

tech-debt, enhancement, todo

Priority

low

## Description `services/base_service.py:510-531` — Contains comment: "This is a placeholder - real implementation would need table-specific endpoints". Blindly POSTs to whatever `table_name` is passed. Used by `custom_commands_service` for creating creator records. ## File Locations - `services/base_service.py:510-531` ## Labels tech-debt, enhancement, todo ## Priority low

cal added the

ai-working

label 2026-03-06 20:01:02 +00:00

cal referenced this issue from a commit

2026-03-06 20:04:20 +00:00

fix: replace create_item_in_table placeholder with direct endpoint call (#30)

cal added the

status/in-progress

label 2026-03-06 20:04:21 +00:00

cal referenced this issue

2026-03-06 20:04:39 +00:00

fix: replace create_item_in_table placeholder with direct endpoint call (#30) #69

cal removed the

status/in-progress

label 2026-03-06 20:04:45 +00:00

cal commented

2026-03-06 20:04:49 +00:00

PR #69 opened: #69

Fix approach: Removed the create_item_in_table placeholder from BaseService and replaced the single call site in CustomCommandsService.get_or_create_creator with a direct client.post("custom_commands/creators", creator_data) — the same pattern already used by _update_creator_stats and _update_creator_info for other creator sub-endpoint operations.

PR #69 opened: https://git.manticorum.com/cal/major-domo-v2/pulls/69 **Fix approach:** Removed the `create_item_in_table` placeholder from `BaseService` and replaced the single call site in `CustomCommandsService.get_or_create_creator` with a direct `client.post("custom_commands/creators", creator_data)` — the same pattern already used by `_update_creator_stats` and `_update_creator_info` for other creator sub-endpoint operations.

cal added

status/pr-open

ai-pr-opened

and removed

ai-working

labels 2026-03-06 20:04:58 +00:00

cal referenced this issue from a commit

2026-03-07 03:25:10 +00:00

Merge pull request 'fix: replace create_item_in_table placeholder with direct endpoint call (#30)' (#69) from ai/major-domo-v2#30 into main

cal closed this issue

2026-03-10 18:26:34 +00:00

Sign in to join this conversation.