cal/major-domo-v2
1
0
Fork 0
Code Issues 6 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Implement actual maintenance mode flag in /admin-maintenance #28

New Issue
Closed
opened 2026-02-20 06:49:52 +00:00 by cal · 1 comment
cal commented 2026-02-20 06:49:52 +00:00
Owner
Copy Link

Description

commands/admin/management.py:479-480 — The admin maintenance toggle only shows a UI embed. No flag is set, no commands are blocked, no state changes. Users see success but nothing actually happens.

File Locations

  • commands/admin/management.py:479-480

Labels

bug, enhancement, todo

Priority

medium

## Description `commands/admin/management.py:479-480` — The admin maintenance toggle only shows a UI embed. No flag is set, no commands are blocked, no state changes. Users see success but nothing actually happens. ## File Locations - `commands/admin/management.py:479-480` ## Labels bug, enhancement, todo ## Priority medium
cal commented 2026-03-03 17:37:17 +00:00
Author
Owner
Copy Link

Fixed in PR #62.

Approach: Added maintenance_mode: bool = False to SBABot.__init__ and registered a global @tree.interaction_check that blocks non-admin users from all slash commands when the flag is set. The /admin-maintenance command now sets self.bot.maintenance_mode directly and logs the state change. Admins retain full access during maintenance.

Fixed in PR #62. **Approach:** Added `maintenance_mode: bool = False` to `SBABot.__init__` and registered a global `@tree.interaction_check` that blocks non-admin users from all slash commands when the flag is set. The `/admin-maintenance` command now sets `self.bot.maintenance_mode` directly and logs the state change. Admins retain full access during maintenance.
cal added the
ai-pr-opened
 label 2026-03-03 17:37:39 +00:00
cal closed this issue 2026-03-03 22:08:21 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-changes-requested

   
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-working

   
in-next-release

Fix included in the next-release branch, pending merge to main

  
status/in-progress

Work is actively in progress

  
status/pr-open

A pull request has been opened for this issue

No Label
ai-changes-requested
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
in-next-release
status/in-progress
status/pr-open
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/major-domo-v2#28
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?