cal/major-domo-v2
1
0
Fork 0
Code Issues 6 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Replace bare except: with except Exception: and log errors #23

New Issue
Closed
opened 2026-02-20 06:49:22 +00:00 by cal · 2 comments
cal commented 2026-02-20 06:49:22 +00:00
Owner
Copy Link

Description

Seven bare except: pass blocks exist across production code: commands/league/submit_scorecard.py:178, :185, :357, :375, views/transaction_embed.py:383, tasks/transaction_freeze.py:821, :916. Bare except: catches KeyboardInterrupt, SystemExit, and GeneratorExit, which can prevent clean shutdown.

File Locations

  • commands/league/submit_scorecard.py:178
  • commands/league/submit_scorecard.py:185
  • commands/league/submit_scorecard.py:357
  • commands/league/submit_scorecard.py:375
  • views/transaction_embed.py:383
  • tasks/transaction_freeze.py:821
  • tasks/transaction_freeze.py:916

Labels

bug, tech-debt

Priority

medium

## Description Seven bare `except: pass` blocks exist across production code: `commands/league/submit_scorecard.py:178, :185, :357, :375`, `views/transaction_embed.py:383`, `tasks/transaction_freeze.py:821, :916`. Bare `except:` catches `KeyboardInterrupt`, `SystemExit`, and `GeneratorExit`, which can prevent clean shutdown. ## File Locations - `commands/league/submit_scorecard.py:178` - `commands/league/submit_scorecard.py:185` - `commands/league/submit_scorecard.py:357` - `commands/league/submit_scorecard.py:375` - `views/transaction_embed.py:383` - `tasks/transaction_freeze.py:821` - `tasks/transaction_freeze.py:916` ## Labels bug, tech-debt ## Priority medium
cal commented 2026-02-20 16:48:27 +00:00
Author
Owner
Copy Link

Addressed in commit f4be20a on next-release branch. Will be closed when merged to main.

Addressed in commit f4be20a on `next-release` branch. Will be closed when merged to main.
cal commented 2026-02-20 16:48:34 +00:00
Author
Owner
Copy Link

Addressed in commit f4be20a on next-release branch. Will be closed when merged to main.

Addressed in commit `f4be20a` on `next-release` branch. Will be closed when merged to main.
cal closed this issue 2026-02-20 20:29:06 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-changes-requested

   
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-working

   
in-next-release

Fix included in the next-release branch, pending merge to main

  
status/in-progress

Work is actively in progress

  
status/pr-open

A pull request has been opened for this issue

No Label
ai-changes-requested
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
in-next-release
status/in-progress
status/pr-open
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/major-domo-v2#23
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?