Clean up obsolete MoveAction test stubs in test_commands_dropadd.py #16

New Issue

cal · 2026-02-20T04:22:04Z

cal commented

2026-02-20 04:22:04 +00:00

Found in tests/test_commands_dropadd.py:287:

# TODO: These tests are for obsolete MoveAction-based functionality
# The transaction system now uses from_roster/to_roster directly
# def test_determine_roster_types_add(self, commands_cog):
# def test_determine_roster_types_drop(self, commands_cog):
# def test_determine_roster_types_recall(self, commands_cog):
# def test_determine_roster_types_demote(self, commands_cog):
pass  # Placeholder

These commented-out tests reference the old MoveAction-based transaction system. The transaction system now uses from_roster/to_roster directly, so these stubs are dead code.

Either remove them entirely or replace with tests covering the current from_roster/to_roster approach.

Found in `tests/test_commands_dropadd.py:287`: ```python # TODO: These tests are for obsolete MoveAction-based functionality # The transaction system now uses from_roster/to_roster directly # def test_determine_roster_types_add(self, commands_cog): # def test_determine_roster_types_drop(self, commands_cog): # def test_determine_roster_types_recall(self, commands_cog): # def test_determine_roster_types_demote(self, commands_cog): pass # Placeholder ``` These commented-out tests reference the old `MoveAction`-based transaction system. The transaction system now uses `from_roster/to_roster` directly, so these stubs are dead code. Either remove them entirely or replace with tests covering the current `from_roster/to_roster` approach.

cal referenced this issue from a commit

2026-02-20 04:28:50 +00:00

chore: remove obsolete MoveAction test stubs

cal closed this issue

2026-02-20 20:28:17 +00:00

Sign in to join this conversation.