perf: cache inspect.signature() at decoration time (#97) #107

Claude · 2026-03-20T16:33:59Z

Claude commented

2026-03-20 16:33:59 +00:00

Closes #97

Summary

Moves inspect.signature(func) calls from inside wrapper functions to the outer decorator function, so the introspection cost is paid once at decoration time rather than on every invocation.

Changes in `utils/decorators.py`

logged_command: sig, param_names, and exclude_set are now computed in decorator(func) and closed over by wrapper. wrapper.__signature__ reuses the pre-computed sig instead of calling inspect.signature a second time.
cached_api_call: sig = inspect.signature(func) moved to decorator scope. bound_args = sig.bind(...) stays in the wrapper since it requires runtime args.
cached_single_item: Same pattern as cached_api_call.

Test results

11/11 decorator tests pass. 935/935 unaffected tests pass. 18 pre-existing failures from unrelated modified working-tree files (charts.py, scorecard_tracker.py) — not caused by this change.

Other observations

The linter (ruff) reformatted surrounding code (quote style, trailing commas, line-length wrapping) on the touched lines — cosmetic only, no behavioral change.

Closes #97 ## Summary Moves `inspect.signature(func)` calls from inside wrapper functions to the outer `decorator` function, so the introspection cost is paid once at decoration time rather than on every invocation. ### Changes in `utils/decorators.py` - **`logged_command`**: `sig`, `param_names`, and `exclude_set` are now computed in `decorator(func)` and closed over by `wrapper`. `wrapper.__signature__` reuses the pre-computed `sig` instead of calling `inspect.signature` a second time. - **`cached_api_call`**: `sig = inspect.signature(func)` moved to `decorator` scope. `bound_args = sig.bind(...)` stays in the wrapper since it requires runtime args. - **`cached_single_item`**: Same pattern as `cached_api_call`. ## Test results 11/11 decorator tests pass. 935/935 unaffected tests pass. 18 pre-existing failures from unrelated modified working-tree files (`charts.py`, `scorecard_tracker.py`) — not caused by this change. ## Other observations - The linter (ruff) reformatted surrounding code (quote style, trailing commas, line-length wrapping) on the touched lines — cosmetic only, no behavioral change.

Claude added 1 commit 2026-03-20 16:34:00 +00:00

perf: cache inspect.signature() at decoration time (#97 )

Build Docker Image / build (pull_request) Successful in 1m24s

Details

678f7d71e0

Move inspect.signature(func) calls from inside wrapper functions to the
outer decorator function so the introspection cost is paid once at
decoration time instead of on every invocation.

- logged_command: sig, param_names, and exclude_set computed at decoration time;
  wrapper.__signature__ reuses the pre-computed sig
- cached_api_call: sig moved to decorator scope; bound_args still computed
  per-call (requires runtime args)
- cached_single_item: same as cached_api_call

Closes #97

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Claude referenced this pull request

2026-03-20 16:34:07 +00:00

perf: cache inspect.signature() at decoration time in logged_command and cache decorators #97

Claude added the

ai-reviewing

label 2026-03-20 16:45:49 +00:00

Claude reviewed 2026-03-20 16:47:14 +00:00

Claude left a comment

Review: perf: cache inspect.signature() at decoration time (#97)

Verdict: APPROVED (posted as COMMENT — Gitea blocks self-review on cal-owned repos)

Summary

Clean, correct performance optimization. All three inspect.signature() call movements are semantically safe, and the refactor produces identical observable behavior at a lower per-invocation cost.

Correctness Analysis

logged_command: sig, param_names, and exclude_set are all derived purely from func and exclude_params, which are fixed at decoration time. Moving them to decorator scope is sound. One micro-observation: param_names and exclude_set are now computed even when log_params=False, but this cost is paid once at decoration time so it's negligible. wrapper.__signature__ = sig reuses the same value that was previously re-computed — correct.

cached_api_call / cached_single_item: sig = inspect.signature(func) moved to decorator scope; sig.bind(self, *args, **kwargs) correctly remains in wrapper (needs runtime args). The Signature object is read-only after creation, so sharing it across concurrent async invocations via closure is safe — bind() creates a fresh BoundArguments each time.

requires_draft_period / cache_invalidate: No structural changes. requires_draft_period already called inspect.signature(func) once at decoration time (single-level decorator, not a factory), so nothing to optimize. Cosmetic formatting only.

Test Coverage

11/11 existing decorator tests pass and continue to cover all observable behavior: signature preservation, param logging, exclusion, auto-naming, error path, logger fallback. The refactored paths are exercised by these tests. No new tests needed for a pure performance optimization with no behavior change. cached_api_call and cached_single_item remain untested (pre-existing gap, not introduced here).

Observations

Branch target: PR targets main directly (as opposed to next-release). Recent perf PRs (#100, #101) targeted next-release; this one doesn't. Minor workflow inconsistency but not a blocker for a low-risk optimization.
Mergeable: true — no conflicts.
Linter reformats: Quote style and trailing commas are cosmetic; no behavioral change confirmed.

No Issues Found

✅ Logic correct
✅ Thread/concurrency safe
✅ No mutation risk on closure-captured values
✅ 935 tests passing, 18 pre-existing unrelated failures

Ready to merge.

## Review: perf: cache inspect.signature() at decoration time (#97) **Verdict: APPROVED** (posted as COMMENT — Gitea blocks self-review on cal-owned repos) --- ### Summary Clean, correct performance optimization. All three `inspect.signature()` call movements are semantically safe, and the refactor produces identical observable behavior at a lower per-invocation cost. --- ### Correctness Analysis **`logged_command`**: `sig`, `param_names`, and `exclude_set` are all derived purely from `func` and `exclude_params`, which are fixed at decoration time. Moving them to `decorator` scope is sound. One micro-observation: `param_names` and `exclude_set` are now computed even when `log_params=False`, but this cost is paid once at decoration time so it's negligible. `wrapper.__signature__ = sig` reuses the same value that was previously re-computed — correct. **`cached_api_call` / `cached_single_item`**: `sig = inspect.signature(func)` moved to `decorator` scope; `sig.bind(self, *args, **kwargs)` correctly remains in `wrapper` (needs runtime args). The `Signature` object is read-only after creation, so sharing it across concurrent async invocations via closure is safe — `bind()` creates a fresh `BoundArguments` each time. **`requires_draft_period` / `cache_invalidate`**: No structural changes. `requires_draft_period` already called `inspect.signature(func)` once at decoration time (single-level decorator, not a factory), so nothing to optimize. Cosmetic formatting only. --- ### Test Coverage 11/11 existing decorator tests pass and continue to cover all observable behavior: signature preservation, param logging, exclusion, auto-naming, error path, logger fallback. The refactored paths are exercised by these tests. No new tests needed for a pure performance optimization with no behavior change. `cached_api_call` and `cached_single_item` remain untested (pre-existing gap, not introduced here). --- ### Observations - **Branch target**: PR targets `main` directly (as opposed to `next-release`). Recent perf PRs (#100, #101) targeted `next-release`; this one doesn't. Minor workflow inconsistency but not a blocker for a low-risk optimization. - **Mergeable**: `true` — no conflicts. - **Linter reformats**: Quote style and trailing commas are cosmetic; no behavioral change confirmed. --- ### No Issues Found ✅ Logic correct ✅ Thread/concurrency safe ✅ No mutation risk on closure-captured values ✅ 935 tests passing, 18 pre-existing unrelated failures Ready to merge.

cal changed target branch from main to next-release

2026-03-20 17:44:54 +00:00

cal force-pushed ai/major-domo-v2-97 from 678f7d71e0 to a3e63f730f

2026-03-20 17:45:14 +00:00

Compare

cal merged commit 498fcdfe51 into next-release

2026-03-20 17:45:52 +00:00

cal deleted branch ai/major-domo-v2-97

2026-03-20 17:45:53 +00:00

cal referenced this issue from a commit

2026-03-20 17:45:55 +00:00

Merge pull request 'perf: cache inspect.signature() at decoration time (#97)' (#107) from ai/major-domo-v2-97 into next-release