cal/major-domo-v2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CLAUDE: Remove duplicate emojis from EmbedTemplate method calls

Browse Source 
Fixed 14 instances across 6 command files where manual emojis were added
to titles when EmbedTemplate methods already add them automatically.

Changes:
- commands/soak/info.py: Removed 📊 from info() title
- commands/help/main.py: Removed 📚, ✅, ⚠️ from various titles (4 fixes)
- commands/profile/images.py: Removed ✅ from success() title
- commands/voice/channels.py: Removed 📢 from deprecated command titles (2 fixes)
- commands/custom_commands/main.py: Removed ✅, 📝 from titles (3 fixes)
- commands/utilities/charts.py: Removed ✅ from admin command titles (3 fixes)

This prevents double emoji rendering (e.g., "ℹ️ 📊 Last Soak" now shows as "ℹ️ Last Soak")
since EmbedTemplate.success/error/warning/info/loading methods automatically prepend
the appropriate emoji to the title.
This commit is contained in:
Cal Corum 2025-10-14 00:43:05 -05:00
parent 2e1e3361a1
commit c5fecc878f
6 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
commands/custom_commands/main.py
View File

@ -119,7 +119,7 @@ class CustomCommandsCommands(commands.Cog):
# Success embed
embed = EmbedTemplate.success(
title="✅ Custom Command Created!",
title="Custom Command Created!",
description=f"Your command `/cc {command.name}` has been created successfully."
)
@ -200,7 +200,7 @@ class CustomCommandsCommands(commands.Cog):
# Success embed
embed = EmbedTemplate.success(
title="✅ Command Updated!",
title="Command Updated!",
description=f"Your command `/cc {updated_command.name}` has been updated successfully."
)
@ -349,7 +349,7 @@ class CustomCommandsCommands(commands.Cog):
if not search_result.commands:
embed = EmbedTemplate.info(
title="📝 Your Custom Commands",
title="Your Custom Commands",
description="You haven't created any custom commands yet!"
)

8
commands/help/main.py
View File

@ -95,7 +95,7 @@ class HelpCommands(commands.Cog):
if not all_topics:
embed = EmbedTemplate.info(
title="📚 Help Topics",
title="Help Topics",
description="No help topics are currently available.\nAdmins can create topics using `/help-create`."
)
await interaction.followup.send(embed=embed)
@ -247,7 +247,7 @@ class HelpCommands(commands.Cog):
# Success embed
embed = EmbedTemplate.success(
title="✅ Help Topic Updated!",
title="Help Topic Updated!",
description=f"The help topic `/help {updated_help.name}` has been updated successfully."
)
@ -303,7 +303,7 @@ class HelpCommands(commands.Cog):
# Show deletion confirmation
embed = EmbedTemplate.warning(
title="⚠️ Delete Help Topic",
title="Delete Help Topic",
description=f"Are you sure you want to delete `/help {help_cmd.name}`?"
)
@ -389,7 +389,7 @@ class HelpCommands(commands.Cog):
if not all_topics:
embed = EmbedTemplate.info(
title="📚 Help Topics",
title="Help Topics",
description="No help topics found matching your criteria."
)

2
commands/profile/images.py
View File

@ -427,7 +427,7 @@ class ImageCommands(commands.Cog):
)
success_embed = EmbedTemplate.success(
title="✅ Image Updated Successfully!",
title="Image Updated Successfully!",
description=f"**{display_name}** for **{player.name}** has been updated."
)

2
commands/soak/info.py
View File

@ -34,7 +34,7 @@ class SoakInfoCommands(commands.Cog):
# Handle case where soak has never been mentioned
if not last_soak:
embed = EmbedTemplate.info(
title="📊 Last Soak",
title="Last Soak",
description="No one has said the forbidden word yet. 🤫"
)
embed.add_field(

6
commands/utilities/charts.py
View File

@ -169,7 +169,7 @@ class ChartAdminCommands(commands.Cog):
# Success response
embed = EmbedTemplate.success(
title="✅ Chart Added",
title="Chart Added",
description=f"Successfully added chart '{name}'"
)
embed.add_field(name="Key", value=key, inline=True)
@ -207,7 +207,7 @@ class ChartAdminCommands(commands.Cog):
# Success response
embed = EmbedTemplate.success(
title="✅ Chart Removed",
title="Chart Removed",
description=f"Successfully removed chart '{chart.name}'"
)
embed.add_field(name="Key", value=key, inline=True)
@ -335,7 +335,7 @@ class ChartAdminCommands(commands.Cog):
# Success response
embed = EmbedTemplate.success(
title="✅ Chart Updated",
title="Chart Updated",
description=f"Successfully updated chart '{chart.name}'"
)
embed.add_field(name="Key", value=key, inline=True)

4
commands/voice/channels.py
View File

@ -339,7 +339,7 @@ class VoiceChannelCommands(commands.Cog):
async def deprecated_public_voice(self, ctx: commands.Context):
"""Deprecated command - redirect to new slash command."""
embed = EmbedTemplate.info(
title="📢 Command Deprecated",
title="Command Deprecated",
description=(
"The `!vc` command has been deprecated.\n\n"
"**Please use:** `/voice-channel public` for your voice channel needs.\n\n"
@ -353,7 +353,7 @@ class VoiceChannelCommands(commands.Cog):
async def deprecated_private_voice(self, ctx: commands.Context):
"""Deprecated command - redirect to new slash command."""
embed = EmbedTemplate.info(
title="📢 Command Deprecated",
title="Command Deprecated",
description=(
"The `!private` command has been deprecated.\n\n"
"**Please use:** `/voice-channel private` for your private team channel needs.\n\n"