cal/major-domo-database
1
0
Fork 0
Code Issues 25 Pull Requests 25 Actions Packages Projects Releases Wiki Activity

fix: move hardcoded Discord webhook URL to env var #83

Open
cal wants to merge 3 commits from fix/remove-hardcoded-webhook into main
pull from: fix/remove-hardcoded-webhook
merge into: cal:main
Conversation 0 Commits 3 Files Changed 3 +7 -3
3 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 1bcde424c6 - Show all commits

3
.env
View File

@ -6,6 +6,9 @@ SBA_DB_USER_PASSWORD=your_production_password
# SBa API
API_TOKEN=Tp3aO3jhYve5NJF1IqOmJTmk
# Integrations
DISCORD_WEBHOOK_URL=
# Universal
TZ=America/Chicago
LOG_LEVEL=INFO

6
app/dependencies.py
View File

@ -22,6 +22,9 @@ logger = logging.getLogger("discord_app")
# level=log_level
# )
# Discord integration
DISCORD_WEBHOOK_URL = os.environ.get("DISCORD_WEBHOOK_URL")
# Redis configuration
REDIS_HOST = os.environ.get("REDIS_HOST", "localhost")
REDIS_PORT = int(os.environ.get("REDIS_PORT", "6379"))
@ -503,9 +506,6 @@ def update_season_pitching_stats(player_ids, season, db_connection):
raise
cal commented 2026-03-27 04:17:02 +00:00
Outdated
Review
Copy Link

All other env-var module-level constants (REDIS_HOST, REDIS_PORT, REDIS_DB, CACHE_ENABLED) are grouped together near the top of the file around lines 26–29. Declaring this one mid-file is inconsistent with that pattern. Consider moving it there.

All other env-var module-level constants (`REDIS_HOST`, `REDIS_PORT`, `REDIS_DB`, `CACHE_ENABLED`) are grouped together near the top of the file around lines 26–29. Declaring this one mid-file is inconsistent with that pattern. Consider moving it there.
DISCORD_WEBHOOK_URL = os.environ.get("DISCORD_WEBHOOK_URL")
def send_webhook_message(message: str) -> bool:
"""
Send a message to Discord via webhook.

1
docker-compose.yml
View File

@ -34,6 +34,7 @@ services:
- REDIS_HOST=sba_redis
- REDIS_PORT=6379
- REDIS_DB=0
- DISCORD_WEBHOOK_URL=${DISCORD_WEBHOOK_URL}
depends_on:
- postgres
- redis