cal/major-domo-database
1
0
Fork 0
Code Issues 25 Pull Requests 25 Actions Packages Projects Releases Wiki Activity

fix: let HTTPException pass through @handle_db_errors #104

Merged
cal merged 2 commits from fix/handle-db-errors-passthrough-http into main 2026-04-02 16:57:14 +00:00
Conversation 1 Commits 2 Files Changed 2 +18 -15
2 changed files with 18 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/dependencies.py
View File

@ -807,6 +807,10 @@ def handle_db_errors(func):
return result return result
except HTTPException:
# Let intentional HTTP errors (401, 404, etc.) pass through unchanged
raise
except Exception as e: except Exception as e:
elapsed_time = time.time() - start_time elapsed_time = time.time() - start_time
error_trace = traceback.format_exc() error_trace = traceback.format_exc()

29
tests/integration/test_stratplay_routes.py
View File

@ -81,9 +81,9 @@ class TestRouteRegistration:
for route, methods in EXPECTED_PLAY_ROUTES.items(): for route, methods in EXPECTED_PLAY_ROUTES.items():
assert route in paths, f"Route {route} missing from OpenAPI schema" assert route in paths, f"Route {route} missing from OpenAPI schema"
for method in methods: for method in methods:
assert ( assert method in paths[route], (
method in paths[route] f"Method {method.upper()} missing for {route}"
), f"Method {method.upper()} missing for {route}" )
def test_play_routes_have_plays_tag(self, api): def test_play_routes_have_plays_tag(self, api):
"""All play routes should be tagged with 'plays'.""" """All play routes should be tagged with 'plays'."""
@ -96,9 +96,9 @@ class TestRouteRegistration:
for method, spec in paths[route].items(): for method, spec in paths[route].items():
if method in ("get", "post", "patch", "delete"): if method in ("get", "post", "patch", "delete"):
tags = spec.get("tags", []) tags = spec.get("tags", [])
assert ( assert "plays" in tags, (
"plays" in tags f"{method.upper()} {route} missing 'plays' tag, has {tags}"
), f"{method.upper()} {route} missing 'plays' tag, has {tags}" )
@pytest.mark.post_deploy @pytest.mark.post_deploy
@pytest.mark.skip( @pytest.mark.skip(
@ -124,9 +124,9 @@ class TestRouteRegistration:
]: ]:
params = paths[route]["get"].get("parameters", []) params = paths[route]["get"].get("parameters", [])
param_names = [p["name"] for p in params] param_names = [p["name"] for p in params]
assert ( assert "sbaplayer_id" in param_names, (
"sbaplayer_id" in param_names f"sbaplayer_id parameter missing from {route}"
), f"sbaplayer_id parameter missing from {route}" )
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
@ -493,10 +493,9 @@ class TestPlayCrud:
assert result["id"] == play_id assert result["id"] == play_id
def test_get_nonexistent_play(self, api): def test_get_nonexistent_play(self, api):
"""GET /plays/999999999 returns an error (wrapped by handle_db_errors).""" """GET /plays/999999999 returns 404 Not Found."""
r = requests.get(f"{api}/api/v3/plays/999999999", timeout=10) r = requests.get(f"{api}/api/v3/plays/999999999", timeout=10)
# handle_db_errors wraps HTTPException as 500 with detail message assert r.status_code == 404
assert r.status_code == 500
assert "not found" in r.json().get("detail", "").lower() assert "not found" in r.json().get("detail", "").lower()
Claude commented 2026-04-02 13:48:54 +00:00
Review
Copy Link

This assertion documents the old broken behavior and will fail after this fix. GET /plays/999999999 now correctly returns 404 (from crud.py:24's HTTPException(status_code=404, ...)), not 500.

Change to:

assert r.status_code == 404

and update the docstring/comment accordingly.

This assertion documents the old broken behavior and will fail after this fix. `GET /plays/999999999` now correctly returns 404 (from `crud.py:24`'s `HTTPException(status_code=404, ...)`), not 500. Change to: ```python assert r.status_code == 404 ``` and update the docstring/comment accordingly.
@ -575,9 +574,9 @@ class TestGroupBySbaPlayer:
) )
assert r_seasons.status_code == 200 assert r_seasons.status_code == 200
season_pas = [s["pa"] for s in r_seasons.json()["stats"]] season_pas = [s["pa"] for s in r_seasons.json()["stats"]]
assert career_pa >= max( assert career_pa >= max(season_pas), (
season_pas f"Career PA ({career_pa}) should be >= max season PA ({max(season_pas)})"
), f"Career PA ({career_pa}) should be >= max season PA ({max(season_pas)})" )
@pytest.mark.post_deploy @pytest.mark.post_deploy
def test_batting_sbaplayer_short_output(self, api): def test_batting_sbaplayer_short_output(self, api):