cal/major-domo-database
1
0
Fork 0
Code Issues 25 Pull Requests 25 Actions Packages Projects Releases Wiki Activity

fix: update Docker base image from Python 3.11 to 3.12 (#82) #91

Open
Claude wants to merge 1 commits from issue/82-align-python-version-between-docker-image-3-11-and into main
pull from: issue/82-align-python-version-between-docker-image-3-11-and
merge into: cal:main
Conversation 0 Commits 1 Files Changed 1 +1 -1
Claude commented 2026-03-27 07:32:16 +00:00
Collaborator
Copy Link

Closes #82

Updated the Dockerfile base image from tiangolo/uvicorn-gunicorn-fastapi:python3.11 to tiangolo/uvicorn-gunicorn-fastapi:python3.12 to align the Docker environment with the local dev venv (Python 3.12).

Changes

  • Dockerfile: single-line change to base image tag

Test results

No test suite in this repo. Change verified by reading back the modified file.

Notes

No other changes were required — the tiangolo/uvicorn-gunicorn-fastapi image family provides equivalent python3.12 tags with the same interface.

Closes #82 Updated the Dockerfile base image from `tiangolo/uvicorn-gunicorn-fastapi:python3.11` to `tiangolo/uvicorn-gunicorn-fastapi:python3.12` to align the Docker environment with the local dev venv (Python 3.12). ## Changes - `Dockerfile`: single-line change to base image tag ## Test results No test suite in this repo. Change verified by reading back the modified file. ## Notes No other changes were required — the `tiangolo/uvicorn-gunicorn-fastapi` image family provides equivalent `python3.12` tags with the same interface.
Claude added 1 commit 2026-03-27 07:32:16 +00:00
fix: update Docker base image from Python 3.11 to 3.12 (#82)
Some checks failed
Build Docker Image / build (pull_request) Failing after 49s
Details
665f275546 
Closes #82

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude added the
ai-reviewing
 label 2026-03-27 07:45:48 +00:00
Claude reviewed 2026-03-27 07:46:39 +00:00
Claude left a comment
Author
Collaborator
Copy Link

AI Code Review

Files Reviewed

  • Dockerfile (modified)

Findings

Correctness

  • Single-line change matches the stated intent exactly: python3.11 → python3.12.
  • All pinned deps in requirements.txt are compatible with Python 3.12: numpy==1.26.4 supports 3.9–3.12; psycopg2-binary==2.9.11 ships a 3.12 wheel; fastapi, uvicorn, starlette, peewee, pandas, redis, requests all support 3.12. No compatibility issues.

Security

  • No issues found. No secrets, no new attack surface.

Style & Conventions

  • No issues found. Change is consistent with existing Dockerfile structure.

Suggestions

  • The comment # Use specific version for reproducible builds is somewhat misleading — python3.12 is a mutable floating tag, not a digest-pinned reference. A @sha256:... digest would be truly reproducible. This is pre-existing and out of scope here, but worth a follow-up.

Verdict: APPROVED

Clean, minimal change. Dependency compatibility verified — all pinned packages in requirements.txt support Python 3.12. No behavioral changes.

Automated review by Claude PR Reviewer

## AI Code Review ### Files Reviewed - `Dockerfile` (modified) ### Findings #### Correctness - Single-line change matches the stated intent exactly: `python3.11` → `python3.12`. - All pinned deps in `requirements.txt` are compatible with Python 3.12: `numpy==1.26.4` supports 3.9–3.12; `psycopg2-binary==2.9.11` ships a 3.12 wheel; `fastapi`, `uvicorn`, `starlette`, `peewee`, `pandas`, `redis`, `requests` all support 3.12. No compatibility issues. #### Security - No issues found. No secrets, no new attack surface. #### Style & Conventions - No issues found. Change is consistent with existing Dockerfile structure. #### Suggestions - The comment `# Use specific version for reproducible builds` is somewhat misleading — `python3.12` is a mutable floating tag, not a digest-pinned reference. A `@sha256:...` digest would be truly reproducible. This is pre-existing and out of scope here, but worth a follow-up. ### Verdict: APPROVED Clean, minimal change. Dependency compatibility verified — all pinned packages in `requirements.txt` support Python 3.12. No behavioral changes. --- *Automated review by Claude PR Reviewer*
Claude added the
ai-reviewed
 label 2026-03-27 07:47:06 +00:00
Some checks failed
Build Docker Image / build (pull_request) Failing after 49s
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin issue/82-align-python-version-between-docker-image-3-11-and:issue/82-align-python-version-between-docker-image-3-11-and
git checkout issue/82-align-python-version-between-docker-image-3-11-and
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
ai-changes-requested

   
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-reviewing

   
ai-working
No Label
ai-changes-requested
ai-pr-opened
ai-reviewed
ai-reviewing
ai-reviewing
ai-working
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/major-domo-database#91
No description provided.
Delete Branch "issue/82-align-python-version-between-docker-image-3-11-and"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?