Stop logging raw auth tokens in warning messages #79
Labels
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cal/major-domo-database#79
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
Multiple routers log the raw token value in warning messages:
The
@handle_db_errorsdecorator redacts tokens in its sanitized kwargs, but routers log the raw value before the decorator runs.Fix
Remove the token value from log messages, or redact it (e.g., show only last 4 characters).
Severity
Low — sensitive data in logs.
Fixed in PR #85. Removed
: {token}from all 73Bad Tokenwarning log messages across 22 router files. The f-string prefix was also dropped where it was no longer needed. Zero remaining occurrences confirmed via grep.