Remove SQLite fallback code from db_engine.py #70

New Issue

cal · 2026-03-27T04:06:18Z

cal commented

2026-03-27 04:06:18 +00:00

Problem

The database initialization in app/db_engine.py (lines 14-39) still contains a full SQLite fallback path with DATABASE_TYPE defaulting to 'sqlite'. The project policy is "PostgreSQL only (no SQLite fallback)."

If DATABASE_TYPE is ever unset, the application silently tries to connect to a SQLite file that doesn't exist in production, causing startup failure with misleading errors.

Fix

Remove the SQLite branch entirely. Default to PostgreSQL and raise a clear error if connection parameters are missing.

Severity

High — risk of silent misconnection and confusing errors.

## Problem The database initialization in `app/db_engine.py` (lines 14-39) still contains a full SQLite fallback path with `DATABASE_TYPE` defaulting to `'sqlite'`. The project policy is "PostgreSQL only (no SQLite fallback)." If `DATABASE_TYPE` is ever unset, the application silently tries to connect to a SQLite file that doesn't exist in production, causing startup failure with misleading errors. ## Fix Remove the SQLite branch entirely. Default to PostgreSQL and raise a clear error if connection parameters are missing. ## Severity High — risk of silent misconnection and confusing errors.

Claude added the

ai-working

label 2026-03-27 06:31:23 +00:00

cal referenced this issue from a commit

2026-03-27 06:34:05 +00:00

fix: remove SQLite fallback code from db_engine.py (#70)

Claude referenced a pull request that will close this issue

2026-03-27 06:34:12 +00:00

fix: remove SQLite fallback code from db_engine.py (#70) #89

Claude added

ai-pr-opened

and removed

ai-working

labels 2026-03-27 06:34:19 +00:00

Claude commented

2026-03-27 06:34:22 +00:00

PR #89 opens the fix: #89

Removed the DATABASE_TYPE conditional and SQLite fallback entirely. PooledPostgresqlDatabase is now initialized unconditionally at module level. Added a RuntimeError at startup if POSTGRES_PASSWORD is unset, which also removes the hardcoded 'sba_dev_password_2024' fallback. Note: PR #84 addresses the same password removal — whichever merges second will need a trivial rebase.

PR #89 opens the fix: https://git.manticorum.com/cal/major-domo-database/pulls/89 Removed the `DATABASE_TYPE` conditional and SQLite fallback entirely. `PooledPostgresqlDatabase` is now initialized unconditionally at module level. Added a `RuntimeError` at startup if `POSTGRES_PASSWORD` is unset, which also removes the hardcoded `'sba_dev_password_2024'` fallback. Note: PR #84 addresses the same password removal — whichever merges second will need a trivial rebase.

Sign in to join this conversation.