Boolean fields compared as integers (SQLite pattern) #69

New Issue

cal · 2026-03-27T04:06:13Z

cal commented

2026-03-27 04:06:13 +00:00

Problem

Boolean fields (Transaction.cancelled, Transaction.frozen) are compared using == 1 / == 0 instead of == True / == False. This is a SQLite-era pattern — SQLite stores booleans as integers, but PostgreSQL uses native booleans.

Peewee's BooleanField adapter handles some conversion, but comparing a boolean column to an integer literal is fragile and semantically incorrect on PostgreSQL.

Locations

app/routers_v3/transactions.py lines 78-85
app/db_engine.py lines 438, 439, 498-503, 559-563

Fix

Change all == 1 to == True and == 0 to == False for boolean fields.

Severity

High — most likely to cause runtime failures if Peewee's implicit casting changes.

## Problem Boolean fields (`Transaction.cancelled`, `Transaction.frozen`) are compared using `== 1` / `== 0` instead of `== True` / `== False`. This is a SQLite-era pattern — SQLite stores booleans as integers, but PostgreSQL uses native booleans. Peewee's `BooleanField` adapter handles some conversion, but comparing a boolean column to an integer literal is fragile and semantically incorrect on PostgreSQL. ## Locations - `app/routers_v3/transactions.py` lines 78-85 - `app/db_engine.py` lines 438, 439, 498-503, 559-563 ## Fix Change all `== 1` to `== True` and `== 0` to `== False` for boolean fields. ## Severity High — most likely to cause runtime failures if Peewee's implicit casting changes.

Claude added the

ai-working

label 2026-03-27 09:01:14 +00:00

cal referenced this issue from a commit

2026-03-27 09:04:04 +00:00

fix: replace integer comparisons on boolean fields with True/False (#69)

Claude referenced a pull request that will close this issue

2026-03-27 09:04:20 +00:00

fix: replace integer comparisons on boolean fields with True/False (#69) #94

Claude added the

ai-pr-opened

label 2026-03-27 09:04:26 +00:00

Claude commented

2026-03-27 09:04:28 +00:00

PR #94 opened: #94

Replaced all 10 integer comparisons on boolean fields with True/False literals:

transactions.py: 4 changes (cancelled == 1/0, frozen == 1/0)
db_engine.py: 6 changes (cancelled == 0 in the active team, SIL team, and LIL team blocks of get_roster_counts())

PR #94 opened: https://git.manticorum.com/cal/major-domo-database/pulls/94 Replaced all 10 integer comparisons on boolean fields with `True`/`False` literals: - `transactions.py`: 4 changes (`cancelled == 1/0`, `frozen == 1/0`) - `db_engine.py`: 6 changes (`cancelled == 0` in the active team, SIL team, and LIL team blocks of `get_roster_counts()`)

Claude removed the

ai-working

label 2026-03-27 09:04:34 +00:00

Sign in to join this conversation.