fix: case-insensitive team_abbrev filter in transactions endpoint #60

cal · 2026-03-08T22:35:28Z

cal commented

2026-03-08 22:35:28 +00:00

Summary

The team_abbrev query filter on GET /transactions uppercased input values but compared against mixed-case DB values (e.g. MKEMiL), causing affiliate roster transactions to be silently dropped from results
Uses fn.UPPER(Team.abbrev) to make the comparison case-insensitive
Fixes issue where querying --team MKE (or MKEMiL) missed transactions like MKEMiL → FA

Test plan

Query GET /transactions?season=13&team_abbrev=MKEMiL&week_start=12&week_end=12 — should return Tobias Myers (MKEMiL → FA)
Query GET /transactions?season=13&team_abbrev=MKE&week_start=12&week_end=12 — should still return all MKE major league transactions as before
Verify no regression on other team queries

🤖 Generated with Claude Code

## Summary - The `team_abbrev` query filter on `GET /transactions` uppercased input values but compared against mixed-case DB values (e.g. `MKEMiL`), causing affiliate roster transactions to be silently dropped from results - Uses `fn.UPPER(Team.abbrev)` to make the comparison case-insensitive - Fixes issue where querying `--team MKE` (or `MKEMiL`) missed transactions like `MKEMiL → FA` ## Test plan - [ ] Query `GET /transactions?season=13&team_abbrev=MKEMiL&week_start=12&week_end=12` — should return Tobias Myers (MKEMiL → FA) - [ ] Query `GET /transactions?season=13&team_abbrev=MKE&week_start=12&week_end=12` — should still return all MKE major league transactions as before - [ ] Verify no regression on other team queries 🤖 Generated with [Claude Code](https://claude.com/claude-code)

cal added 1 commit 2026-03-08 22:35:29 +00:00

fix: case-insensitive team_abbrev filter in transactions endpoint

Build Docker Image / build (pull_request) Successful in 2m7s

Details

6af278d737

The team_abbrev filter uppercased input but compared against mixed-case
DB values (e.g. "MKEMiL"), causing affiliate roster transactions to be
silently dropped from results. Use fn.UPPER() on the DB column to match.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

cal merged commit bc36970aeb into main

2026-03-08 22:37:47 +00:00

cal deleted branch fix/transaction-team-filter-case-insensitive

2026-03-08 22:37:47 +00:00

cal referenced this issue from a commit

2026-03-08 22:37:48 +00:00

Merge pull request 'fix: case-insensitive team_abbrev filter in transactions endpoint' (#60) from fix/transaction-team-filter-case-insensitive into main

cal referenced this pull request from cal/major-domo-v2

2026-03-09 13:10:39 +00:00

fix: re-fetch existing transactions on each validation #72

Sign in to join this conversation.

No reviewers