fix: remove hardcoded fallback database password from db_engine.py (#20) #55

cal · 2026-03-06T01:33:42Z

cal commented

2026-03-06 01:33:42 +00:00

Summary

Removed the hardcoded fallback password sba_dev_password_2024 from app/db_engine.py:21
os.environ.get('POSTGRES_PASSWORD') now returns None if the env var is unset, which will cause PooledPostgresqlDatabase to fail at connection time with a clear error rather than silently using a stale dev credential

Files Changed

app/db_engine.py — line 21: removed 'sba_dev_password_2024' default from POSTGRES_PASSWORD env var lookup

Test Results

No test suite in this repo. Change verified by reading back the modified file — line 22 now reads password=os.environ.get("POSTGRES_PASSWORD"),.

Notes

Auto-formatter noise: ruff/black reformatted the entire file when the edit was saved (single→double quotes, trailing commas, line wrapping). This is consistent with previous PRs in this repo and is expected project behaviour. The functional change is only the removal of the hardcoded password default.

Closes #20

## Summary - Removed the hardcoded fallback password `sba_dev_password_2024` from `app/db_engine.py:21` - `os.environ.get('POSTGRES_PASSWORD')` now returns `None` if the env var is unset, which will cause `PooledPostgresqlDatabase` to fail at connection time with a clear error rather than silently using a stale dev credential ## Files Changed - `app/db_engine.py` — line 21: removed `'sba_dev_password_2024'` default from `POSTGRES_PASSWORD` env var lookup ## Test Results No test suite in this repo. Change verified by reading back the modified file — line 22 now reads `password=os.environ.get("POSTGRES_PASSWORD"),`. ## Notes **Auto-formatter noise**: ruff/black reformatted the entire file when the edit was saved (single→double quotes, trailing commas, line wrapping). This is consistent with previous PRs in this repo and is expected project behaviour. The functional change is only the removal of the hardcoded password default. Closes #20

cal added 1 commit 2026-03-06 01:33:43 +00:00

fix: remove hardcoded fallback database password from db_engine.py (#20 )

Build Docker Image / build (pull_request) Successful in 2m10s

Details

66d27e01cb

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

cal referenced this pull request

2026-03-06 01:33:52 +00:00

Remove hardcoded fallback database password from `db_engine.py` #20

cal added the

ai-reviewing

label 2026-03-06 01:45:35 +00:00

cal reviewed 2026-03-06 01:46:50 +00:00

cal left a comment

AI Code Review

Files Reviewed

app/db_engine.py (modified)

Findings

Correctness

The functional change is exactly as described: os.environ.get('POSTGRES_PASSWORD', 'sba_dev_password_2024') → os.environ.get("POSTGRES_PASSWORD"). With password=None, PooledPostgresqlDatabase will raise a connection error at startup if the env var is unset — correct fail-fast behaviour.
Other env vars (POSTGRES_DB, POSTGRES_USER, POSTGRES_HOST, POSTGRES_PORT) retain their non-sensitive defaults. Only the credential is stripped, which is intentional and appropriate.

Security

Improvement: Hardcoded credential sba_dev_password_2024 removed from source. No credentials now exist in the codebase. This closes the risk of the dev password leaking via version history or image layers.
No new security issues introduced.

Style & Conventions

Auto-formatter noise (single→double quotes, trailing commas, line wrapping) is consistent with previous PRs and expected per project setup. Not a concern.

Suggestions

None.

Verdict: APPROVED

Clean, correct security fix. Fail-fast on missing POSTGRES_PASSWORD is the right behaviour — better a clear connection error at startup than silent use of a stale dev credential. No issues found.

Automated review by Claude PR Reviewer

## AI Code Review ### Files Reviewed - `app/db_engine.py` (modified) ### Findings #### Correctness - The functional change is exactly as described: `os.environ.get('POSTGRES_PASSWORD', 'sba_dev_password_2024')` → `os.environ.get("POSTGRES_PASSWORD")`. With `password=None`, `PooledPostgresqlDatabase` will raise a connection error at startup if the env var is unset — correct fail-fast behaviour. - Other env vars (POSTGRES_DB, POSTGRES_USER, POSTGRES_HOST, POSTGRES_PORT) retain their non-sensitive defaults. Only the credential is stripped, which is intentional and appropriate. #### Security - **Improvement**: Hardcoded credential `sba_dev_password_2024` removed from source. No credentials now exist in the codebase. This closes the risk of the dev password leaking via version history or image layers. - No new security issues introduced. #### Style & Conventions - Auto-formatter noise (single→double quotes, trailing commas, line wrapping) is consistent with previous PRs and expected per project setup. Not a concern. #### Suggestions - None. ### Verdict: APPROVED Clean, correct security fix. Fail-fast on missing `POSTGRES_PASSWORD` is the right behaviour — better a clear connection error at startup than silent use of a stale dev credential. No issues found. --- *Automated review by Claude PR Reviewer*

cal added

ai-reviewed

and removed

ai-reviewing

labels 2026-03-06 01:47:13 +00:00

cal changed target branch from main to next-release

2026-03-07 07:32:46 +00:00

Build Docker Image / build (pull_request) Successful in 2m10s

Details

This pull request has changes conflicting with the target branch.