fix: remove empty WEEK_NUMS dict from db_engine.py (#34) #46

cal · 2026-03-05T18:03:26Z

cal commented

2026-03-05 18:03:26 +00:00

Summary

Removes the WEEK_NUMS module-level constant from app/db_engine.py (lines 54–58). It was an empty dict with a single empty 'regular' key — never referenced anywhere in the codebase.

Changes

app/db_engine.py: deleted 6 lines (the WEEK_NUMS dict definition)

Verification

Grep confirmed zero references to WEEK_NUMS across the entire repository before and after removal.

Test Results

No test suite — verified by reading back the modified file.

## Summary Removes the `WEEK_NUMS` module-level constant from `app/db_engine.py` (lines 54–58). It was an empty dict with a single empty `'regular'` key — never referenced anywhere in the codebase. ## Changes - `app/db_engine.py`: deleted 6 lines (the `WEEK_NUMS` dict definition) ## Verification Grep confirmed zero references to `WEEK_NUMS` across the entire repository before and after removal. ## Test Results No test suite — verified by reading back the modified file.

cal added 1 commit 2026-03-05 18:03:27 +00:00

fix: remove empty WEEK_NUMS dict from db_engine.py (#34 )

Build Docker Image / build (pull_request) Successful in 2m8s

Details

bec280b0b0

Dead code - module-level constant defined but never referenced.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

cal referenced this pull request

2026-03-05 18:03:37 +00:00

Remove the empty `WEEK_NUMS` dict from `db_engine.py` #34

cal added the

ai-reviewing

label 2026-03-05 18:15:34 +00:00

cal reviewed 2026-03-05 18:16:26 +00:00

cal left a comment

AI Code Review

Files Reviewed

app/db_engine.py (modified)

Findings

Correctness

The removal matches exactly what the PR describes: WEEK_NUMS = {'regular': {}} (lines 54–58) is deleted. No logic is affected.
Grep confirms zero references to WEEK_NUMS across the entire repository — the dead code was truly unreachable.

Security

No issues found. Dead code removal only.

Style & Conventions

Removing unused constants is consistent with project hygiene. The resulting file reads cleanly with no orphaned scaffolding.

Suggestions

None.

Verdict: APPROVED

Straightforward dead-code removal. The WEEK_NUMS dict was an empty skeleton ({'regular': {}}) with no references anywhere in the codebase. The change is correct, minimal, and safe to merge.

Automated review by Claude PR Reviewer

## AI Code Review ### Files Reviewed - `app/db_engine.py` (modified) ### Findings #### Correctness - The removal matches exactly what the PR describes: `WEEK_NUMS = {'regular': {}}` (lines 54–58) is deleted. No logic is affected. - Grep confirms zero references to `WEEK_NUMS` across the entire repository — the dead code was truly unreachable. #### Security - No issues found. Dead code removal only. #### Style & Conventions - Removing unused constants is consistent with project hygiene. The resulting file reads cleanly with no orphaned scaffolding. #### Suggestions - None. ### Verdict: APPROVED Straightforward dead-code removal. The `WEEK_NUMS` dict was an empty skeleton (`{'regular': {}}`) with no references anywhere in the codebase. The change is correct, minimal, and safe to merge. --- *Automated review by Claude PR Reviewer*

cal added

ai-reviewed

and removed

ai-reviewing

labels 2026-03-05 18:16:54 +00:00

cal changed target branch from main to next-release

2026-03-07 07:32:39 +00:00

cal merged commit d07e43b195 into next-release

2026-03-10 14:30:31 +00:00

cal deleted branch ai/major-domo-database-34

2026-03-10 14:30:31 +00:00

cal referenced this issue from a commit