fix: Prevent locals() from polluting player PATCH data dict #4

cal · 2026-02-04T21:00:17Z

cal commented

2026-02-04 21:00:17 +00:00

CRITICAL BUG FIX - Root cause of Player.data AttributeError

Problem:
The PATCH endpoint was calling locals() AFTER creating data = {}, causing
locals_dict to capture 'data' and 'locals_dict' as variables. The loop then
added these to the data dict itself, resulting in:
data = {'team_id': 549, 'demotion_week': 7, 'data': {}, 'locals_dict': {...}}

When Peewee executed Player.update(**data), it tried to set Player.data = {},
but Player model has no 'data' field, causing AttributeError.

Solution:

Call locals() BEFORE creating data dict
Exclude 'locals_dict' from the filter (along with 'player_id', 'token')

This ensures only actual player field parameters are included in the update.

Version: 2.5.2 → 2.5.3

Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com

CRITICAL BUG FIX - Root cause of Player.data AttributeError Problem: The PATCH endpoint was calling locals() AFTER creating data = {}, causing locals_dict to capture 'data' and 'locals_dict' as variables. The loop then added these to the data dict itself, resulting in: data = {'team_id': 549, 'demotion_week': 7, 'data': {}, 'locals_dict': {...}} When Peewee executed Player.update(**data), it tried to set Player.data = {}, but Player model has no 'data' field, causing AttributeError. Solution: 1. Call locals() BEFORE creating data dict 2. Exclude 'locals_dict' from the filter (along with 'player_id', 'token') This ensures only actual player field parameters are included in the update. Version: 2.5.2 → 2.5.3 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

cal added 1 commit 2026-02-04 21:00:19 +00:00

fix: Prevent locals() from polluting player PATCH data dict

Build Docker Image / build (pull_request) Has been cancelled

Details

6d36704f35

CRITICAL BUG FIX - Root cause of Player.data AttributeError

Problem:
The PATCH endpoint was calling locals() AFTER creating data = {}, causing
locals_dict to capture 'data' and 'locals_dict' as variables. The loop then
added these to the data dict itself, resulting in:
  data = {'team_id': 549, 'demotion_week': 7, 'data': {}, 'locals_dict': {...}}

When Peewee executed Player.update(**data), it tried to set Player.data = {},
but Player model has no 'data' field, causing AttributeError.

Solution:
1. Call locals() BEFORE creating data dict
2. Exclude 'locals_dict' from the filter (along with 'player_id', 'token')

This ensures only actual player field parameters are included in the update.

Version: 2.5.2 → 2.5.3

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

cal merged commit ffcf0611b7 into main

2026-02-04 21:00:24 +00:00

cal referenced this issue from a commit

2026-02-04 21:00:26 +00:00

Merge pull request 'fix: Prevent locals() from polluting player PATCH data dict' (#4) from fix/locals-pollution-patch-endpoint into main

cal deleted branch fix/locals-pollution-patch-endpoint

2026-02-04 21:00:28 +00:00

Sign in to join this conversation.

No reviewers