Remove db.close() from handle_db_errors error handler #38

New Issue

cal · 2026-02-20T06:51:18Z

cal commented

2026-02-20 06:51:18 +00:00

app/dependencies.py:774-778 — The error handler explicitly closes a pooled database connection after rollback. Combined with manual db.close() calls in route handlers, connections may be returned to the pool twice, causing pool state corruption. Connection management should be centralized.

Priority: medium | Labels: bug, tech-debt

`app/dependencies.py:774-778` — The error handler explicitly closes a pooled database connection after rollback. Combined with manual `db.close()` calls in route handlers, connections may be returned to the pool twice, causing pool state corruption. Connection management should be centralized. **Priority**: medium | **Labels**: bug, tech-debt

cal added the

ai-working

label 2026-03-05 16:01:26 +00:00

cal referenced this issue from a commit

2026-03-05 16:02:50 +00:00

fix: remove db.close() from handle_db_errors error handler (#38)

cal referenced this issue

2026-03-05 16:02:59 +00:00

fix: remove db.close() from handle_db_errors error handler (#38) #42

cal commented

2026-03-05 16:03:07 +00:00

Fixed in PR #42: #42

Removed the finally block from handle_db_errors that called db.close() after rollback. With PostgreSQL connection pooling, route handlers already manage db.close() themselves — closing again in the error handler risked returning connections to the pool twice, corrupting pool state.

Fixed in PR #42: https://git.manticorum.com/cal/major-domo-database/pulls/42 Removed the `finally` block from `handle_db_errors` that called `db.close()` after rollback. With PostgreSQL connection pooling, route handlers already manage `db.close()` themselves — closing again in the error handler risked returning connections to the pool twice, corrupting pool state.

cal added

ai-pr-opened

and removed

ai-working

labels 2026-03-05 16:03:11 +00:00

cal referenced this issue from a commit

2026-03-07 08:01:53 +00:00

fix: restore finally block in handle_db_errors to prevent connection leaks (#38)

Sign in to join this conversation.