chore: drop libpq-dev from Dockerfile (#118) #124
No reviewers
Labels
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cal/major-domo-database#124
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "issue/118-chore-drop-libpq-dev-from-dockerfile"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #118
Summary
Removes
libpq-devfrom theapt-get installline inDockerfile. Thepsycopg2-binarypackage bundles its own libpq, solibpq-devis not needed at build time.curlis retained for theHEALTHCHECK.Files Changed
Dockerfile— removedlibpq-devfrom apt-get install (1 line removed)Tests
No test suite for Dockerfile changes. Change verified by reading back the modified file.
AI Code Review
Files Reviewed
Dockerfile(modified)Findings
Correctness
psycopg2-binary==2.9.11(confirmed inrequirements.txt) bundles its own libpq, solibpq-devis not needed at build or runtime.curlis correctly retained for theHEALTHCHECKon line 30.Security
Style & Conventions
Suggestions
# Install system dependencies (PostgreSQL client libraries)) now refers to PostgreSQL client libraries, but onlycurlremains after this change. Could be updated to something like# Install system dependenciesor# Install curl for healthcheck— non-blocking.Verdict: COMMENT
Change is correct and the rationale is sound. Approved — Gitea blocks self-approval so posting as COMMENT.
Automated review by Claude PR Reviewer