chore: drop libpq-dev from Dockerfile (#118) #124

Merged
cal merged 1 commits from issue/118-chore-drop-libpq-dev-from-dockerfile into main 2026-04-10 15:52:50 +00:00
Collaborator

Closes #118

Summary

Removes libpq-dev from the apt-get install line in Dockerfile. The psycopg2-binary package bundles its own libpq, so libpq-dev is not needed at build time. curl is retained for the HEALTHCHECK.

Files Changed

  • Dockerfile — removed libpq-dev from apt-get install (1 line removed)

Tests

No test suite for Dockerfile changes. Change verified by reading back the modified file.

Closes #118 ## Summary Removes `libpq-dev` from the `apt-get install` line in `Dockerfile`. The `psycopg2-binary` package bundles its own libpq, so `libpq-dev` is not needed at build time. `curl` is retained for the `HEALTHCHECK`. ## Files Changed - `Dockerfile` — removed `libpq-dev` from apt-get install (1 line removed) ## Tests No test suite for Dockerfile changes. Change verified by reading back the modified file.
Claude added 1 commit 2026-04-09 18:31:44 +00:00
psycopg2-binary bundles its own libpq and does not need libpq-dev at
build time. curl is kept for the HEALTHCHECK.

Closes #118

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude added the
ai-reviewing
label 2026-04-09 18:45:51 +00:00
Claude reviewed 2026-04-09 18:46:27 +00:00
Claude left a comment
Author
Collaborator

AI Code Review

Files Reviewed

  • Dockerfile (modified)

Findings

Correctness

  • No issues found. psycopg2-binary==2.9.11 (confirmed in requirements.txt) bundles its own libpq, so libpq-dev is not needed at build or runtime. curl is correctly retained for the HEALTHCHECK on line 30.

Security

  • No issues found. Removing an unneeded development library reduces attack surface.

Style & Conventions

  • No issues found.

Suggestions

  • The comment on line 11 (# Install system dependencies (PostgreSQL client libraries)) now refers to PostgreSQL client libraries, but only curl remains after this change. Could be updated to something like # Install system dependencies or # Install curl for healthcheck — non-blocking.

Verdict: COMMENT

Change is correct and the rationale is sound. Approved — Gitea blocks self-approval so posting as COMMENT.


Automated review by Claude PR Reviewer

## AI Code Review ### Files Reviewed - `Dockerfile` (modified) ### Findings #### Correctness - No issues found. `psycopg2-binary==2.9.11` (confirmed in `requirements.txt`) bundles its own libpq, so `libpq-dev` is not needed at build or runtime. `curl` is correctly retained for the `HEALTHCHECK` on line 30. #### Security - No issues found. Removing an unneeded development library reduces attack surface. #### Style & Conventions - No issues found. #### Suggestions - The comment on line 11 (`# Install system dependencies (PostgreSQL client libraries)`) now refers to PostgreSQL client libraries, but only `curl` remains after this change. Could be updated to something like `# Install system dependencies` or `# Install curl for healthcheck` — non-blocking. ### Verdict: COMMENT Change is correct and the rationale is sound. Approved — Gitea blocks self-approval so posting as COMMENT. --- *Automated review by Claude PR Reviewer*
Claude added the
ai-reviewed
label 2026-04-09 18:46:41 +00:00
Claude removed the
ai-reviewing
label 2026-04-10 15:28:25 +00:00
cal merged commit 18d7a8a758 into main 2026-04-10 15:52:50 +00:00
cal deleted branch issue/118-chore-drop-libpq-dev-from-dockerfile 2026-04-10 15:52:50 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/major-domo-database#124
No description provided.