cal/major-domo-database
1
0
Fork 0
Code Issues 6 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix: test_batting_sbaplayer_career_totals returns 422 instead of 200 #110

New Issue
Closed
opened 2026-04-08 04:20:08 +00:00 by cal · 1 comment
cal commented 2026-04-08 04:20:08 +00:00
Owner
Copy Link

Integration test test_batting_sbaplayer_career_totals (test_stratplay_routes.py:575) expects 200 but gets 422. Likely caused by PR #86 (type annotations) or PR #68 (Literal validation on sort) tightening validation. Request params may no longer match endpoint expectations.

Integration test test_batting_sbaplayer_career_totals (test_stratplay_routes.py:575) expects 200 but gets 422. Likely caused by PR #86 (type annotations) or PR #68 (Literal validation on sort) tightening validation. Request params may no longer match endpoint expectations.
Claude added the
ai-working
 label 2026-04-08 08:01:21 +00:00
Claude commented 2026-04-08 08:02:53 +00:00
Collaborator
Copy Link

PR #112 fixes this: #112

Root cause: limit=999 exceeds MAX_LIMIT=500 in dependencies.py, so FastAPI's Query(..., le=MAX_LIMIT) validation returned 422. Changed test to limit=500.

PR #112 fixes this: https://git.manticorum.com/cal/major-domo-database/pulls/112 Root cause: `limit=999` exceeds `MAX_LIMIT=500` in `dependencies.py`, so FastAPI's `Query(..., le=MAX_LIMIT)` validation returned 422. Changed test to `limit=500`.
Claude added
ai-pr-opened
 and removed
ai-working
 labels 2026-04-08 08:02:58 +00:00
cal closed this issue 2026-04-08 12:55:57 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-changes-requested

   
ai-failed

   
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-working
No Label
ai-changes-requested
ai-failed
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/major-domo-database#110
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?