cal/major-domo-database
1
0
Fork 0
Code Issues 25 Pull Requests 25 Actions Packages Projects Releases Wiki Activity

fix: Replace fragile locals() pattern in PATCH endpoints #11

Merged
cal merged 2 commits from fix/patch-endpoint-locals-bug into main 2026-02-12 15:37:11 +00:00
Conversation 0 Commits 2 Files Changed 3 +26 -12
cal commented 2026-02-11 21:54:58 +00:00
Owner
Copy Link

Summary- Teams PATCH endpoint returned 500 error because locals() captured the data variable itself, causing Peewee to try setting a non-existent Team.data column- Players PATCH had the same fragile pattern with an order-dependent workaround- Both endpoints now use explicit field dicts instead of locals()## Changes- app/routers_v3/teams.py - Replace locals() with explicit dict comprehension- app/routers_v3/players.py - Same fix for consistency and safety## Testing- PATCH /teams/555 with thumbnail param should now return 200- PATCH /players/{id} with any single param should continue working

## Summary- Teams PATCH endpoint returned 500 error because `locals()` captured the `data` variable itself, causing Peewee to try setting a non-existent `Team.data` column- Players PATCH had the same fragile pattern with an order-dependent workaround- Both endpoints now use explicit field dicts instead of `locals()`## Changes- `app/routers_v3/teams.py` - Replace locals() with explicit dict comprehension- `app/routers_v3/players.py` - Same fix for consistency and safety## Testing- PATCH /teams/555 with thumbnail param should now return 200- PATCH /players/{id} with any single param should continue working
cal added 1 commit 2026-02-11 21:54:59 +00:00
fix: Replace fragile locals() pattern in PATCH endpoints with explicit field dicts
Some checks failed
Build Docker Image / build (pull_request) Failing after 15s
Details
31b14ec709 
The teams PATCH endpoint included the `data` variable itself when
building the update dict via locals(), causing Peewee to fail with
"type object 'Team' has no attribute 'data'". The players endpoint
had the same pattern with a workaround that was order-dependent.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cal added 1 commit 2026-02-11 21:55:38 +00:00
Update VERSION
All checks were successful
Build Docker Image / build (pull_request) Successful in 3m16s
Details
e257a96a8a
cal merged commit 7434f69a59 into main 2026-02-12 15:37:11 +00:00
cal deleted branch fix/patch-endpoint-locals-bug 2026-02-12 15:37:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
ai-changes-requested

   
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-reviewing

   
ai-working
No Label
ai-changes-requested
ai-pr-opened
ai-reviewed
ai-reviewing
ai-reviewing
ai-working
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/major-domo-database#11
No description provided.
Delete Branch "fix/patch-endpoint-locals-bug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?