Commit Graph

14 Commits

Author SHA1 Message Date
Cal Corum
099286867a Optimize player search endpoint for 30x performance improvement
All checks were successful
Build Docker Image / build (pull_request) Successful in 2m13s
**Problem:**
The /players/search endpoint with all_seasons=True was taking 15+ seconds,
causing Discord autocomplete timeouts (3-second limit). The endpoint was
loading ALL players from ALL seasons into memory, then doing Python string
matching - extremely inefficient.

**Solution:**
1. Use SQL LIKE filtering at database level instead of Python iteration
2. Limit query results at database level (not after fetching all records)
3. Add functional index on LOWER(name) for faster case-insensitive search

**Performance Impact:**
- Before: 15+ seconds (loads 10,000+ player records)
- After: <500ms (database-level filtering with index)
- 30x faster response time

**Changes:**
- app/services/player_service.py: Use Peewee fn.Lower().contains() for SQL filtering
- migrations/2026-02-06_add_player_name_index.sql: Add index on LOWER(name)
- VERSION: Bump to 2.6.0 (minor version for performance improvement)

**Testing:**
Test with: https://sba.manticorum.com/api/v3/players/search?q=trea%20t&season=0&limit=30

Fixes Discord bot /player autocomplete timeout errors (error code 10062)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-06 07:25:49 -06:00
cal
1216bec287 Update VERSION
All checks were successful
Build Docker Image / build (pull_request) Successful in 3m2s
2026-02-06 02:08:02 +00:00
Cal Corum
927fbe96e3 Bump version 2026-02-05 13:12:55 -06:00
Cal Corum
6d36704f35 fix: Prevent locals() from polluting player PATCH data dict
Some checks failed
Build Docker Image / build (pull_request) Has been cancelled
CRITICAL BUG FIX - Root cause of Player.data AttributeError

Problem:
The PATCH endpoint was calling locals() AFTER creating data = {}, causing
locals_dict to capture 'data' and 'locals_dict' as variables. The loop then
added these to the data dict itself, resulting in:
  data = {'team_id': 549, 'demotion_week': 7, 'data': {}, 'locals_dict': {...}}

When Peewee executed Player.update(**data), it tried to set Player.data = {},
but Player model has no 'data' field, causing AttributeError.

Solution:
1. Call locals() BEFORE creating data dict
2. Exclude 'locals_dict' from the filter (along with 'player_id', 'token')

This ensures only actual player field parameters are included in the update.

Version: 2.5.2 → 2.5.3

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-04 14:57:32 -06:00
Cal Corum
f13815a162 fix: Resolve Player.data AttributeError in patch_player endpoint
All checks were successful
Build Docker Image / build (pull_request) Successful in 2m18s
Fixes critical bug where IL moves and team reassignments failed with:
  "type object 'Player' has no attribute 'data'"

Root Cause:
- model_to_dict() with recurse=True attempted to serialize foreign keys
- Peewee internal serialization incorrectly accessed Player.data class attribute

Changes:
- Add backrefs=False to model_to_dict() to prevent circular reference issues
- Add comprehensive exception handling with graceful fallback
- Fallback chain: recursive → non-recursive → basic dict conversion
- Add warning/error logging to track serialization failures

Impact:
- Fixes /ilmove command failures (player team updates)
- Prevents PATCH /api/v3/players/{id} endpoint errors
- Maintains backward compatibility with all response formats

Version: 2.5.1 → 2.5.2

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-04 14:41:16 -06:00
Cal Corum
d620dfc33d fix: Exclude deprecated pitcher_injury field from player responses
Some checks failed
Build Docker Image / build (pull_request) Has been cancelled
The pitcher_injury column is no longer used but was being included in all
player responses after the service layer refactor. This change restores the
previous behavior of filtering it out.

Changes:
- Add EXCLUDED_FIELDS class constant to PlayerService
- Filter excluded fields in _player_to_dict() method
- Update _query_to_player_dicts() to use _player_to_dict() for all conversions
- Applies to both JSON and CSV responses

Version bump: 2.4.1 -> 2.4.2

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-04 13:55:00 -06:00
Cal Corum
a6610d293d Bump version to 2.4.1
Co-Authored-By: Claude <noreply@anthropic.com>
2026-01-28 16:07:27 -06:00
Cal Corum
b4029d0902 Bump version to 2.4.0 2026-01-23 14:26:19 -06:00
Cal Corum
99f501e748 Fix custom command creator POST validation (v2.3.1)
Changed CustomCommandCreatorModel.id from required `int` to `Optional[int] = None`
to allow POST requests to create new creators without specifying an ID (database
auto-generates it).

Bug: Users couldn't create custom commands with /new-cc - API returned 422 error
"Field required" for missing id field.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-12-13 16:31:47 -06:00
Cal Corum
d53b7259db Release v2.3.0 - Add draft pause support
Added `paused` parameter to DraftData PATCH endpoint for draft pause/resume functionality.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-11 19:47:49 -06:00
Cal Corum
e6a325ac8f Add CACHE_ENABLED env var to toggle Redis caching (v2.2.1)
- Set CACHE_ENABLED=false to disable caching without stopping Redis
- Defaults to true (caching enabled)
- Useful for draft periods requiring real-time data

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-10 07:59:54 -06:00
Cal Corum
254ce2ddc5 Add salary_cap column to Team model (v2.2.0)
- Add optional salary_cap (REAL/float) column to team table
- Create migration file for PostgreSQL schema change
- Update Peewee model with FloatField(null=True)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-10 07:28:16 -06:00
Cal Corum
ef67b716e7 Fix teams endpoint to return results sorted by ID ascending
Added default order_by(Team.id.asc()) to get_teams endpoint to ensure
consistent ordering of results.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-12-03 13:30:50 -06:00
Cal Corum
8f4f4aa321 Add VERSION file for docker build tracking
Initial version: 2.1.2

This file tracks the current version for Docker builds. When building
and pushing new versions, this file will be updated and the commit
will be tagged with the version number.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-15 09:24:44 -06:00