cal/major-domo-database
1
0
Fork 0
Code Issues 25 Pull Requests 25 Actions Packages Projects Releases Wiki Activity

hotfix: remove output caps from GET /players endpoint
All checks were successful
Build Docker Image / build (pull_request) Successful in 2m29s
Details

Browse Source 
The MAX_LIMIT/DEFAULT_LIMIT caps added in 16f3f8d are too restrictive
for the /players endpoint — bot and website consumers need full player
lists without pagination. Reverts limit param to Optional[int] with no
ceiling while keeping caps on all other endpoints.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Cal Corum 2026-04-01 20:14:35 -05:00
parent 81baa54681
commit d92f571960
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/routers_v3/players.py
View File

@ -10,8 +10,6 @@ from ..dependencies import (
oauth2_scheme, oauth2_scheme,
cache_result, cache_result,
handle_db_errors, handle_db_errors,
MAX_LIMIT,
DEFAULT_LIMIT,
) )
from ..services.base import BaseService from ..services.base import BaseService
from ..services.player_service import PlayerService from ..services.player_service import PlayerService
@ -30,7 +28,7 @@ async def get_players(
strat_code: list = Query(default=None), strat_code: list = Query(default=None),
is_injured: Optional[bool] = None, is_injured: Optional[bool] = None,
sort: Optional[str] = None, sort: Optional[str] = None,
limit: int = Query(default=DEFAULT_LIMIT, ge=1, le=MAX_LIMIT), limit: Optional[int] = Query(default=None, ge=1),
offset: Optional[int] = Query( offset: Optional[int] = Query(
default=None, ge=0, description="Number of results to skip for pagination" default=None, ge=0, description="Number of results to skip for pagination"
), ),