feat: Add pagination support to /players endpoint
All checks were successful
Build Docker Image / build (pull_request) Successful in 2m19s
All checks were successful
Build Docker Image / build (pull_request) Successful in 2m19s
Add limit and offset parameters for paginated player queries. Changes: - Add limit parameter (minimum 1) to control page size - Add offset parameter (minimum 0) to skip results - Response now includes both 'count' (current page) and 'total' (all matches) - Pagination applied after filtering and sorting Example usage: /api/v3/players?season=12&limit=50&offset=0 (page 1) /api/v3/players?season=12&limit=50&offset=50 (page 2) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
parent
b5f01f6953
commit
332c445a12
@ -24,6 +24,8 @@ async def get_players(
|
|||||||
strat_code: list = Query(default=None),
|
strat_code: list = Query(default=None),
|
||||||
is_injured: Optional[bool] = None,
|
is_injured: Optional[bool] = None,
|
||||||
sort: Optional[str] = None,
|
sort: Optional[str] = None,
|
||||||
|
limit: Optional[int] = Query(default=None, ge=1, description="Maximum number of results to return"),
|
||||||
|
offset: Optional[int] = Query(default=None, ge=0, description="Number of results to skip for pagination"),
|
||||||
short_output: Optional[bool] = False,
|
short_output: Optional[bool] = False,
|
||||||
csv: Optional[bool] = False,
|
csv: Optional[bool] = False,
|
||||||
):
|
):
|
||||||
@ -36,6 +38,8 @@ async def get_players(
|
|||||||
name=name,
|
name=name,
|
||||||
is_injured=is_injured,
|
is_injured=is_injured,
|
||||||
sort=sort,
|
sort=sort,
|
||||||
|
limit=limit,
|
||||||
|
offset=offset,
|
||||||
short_output=short_output or False,
|
short_output=short_output or False,
|
||||||
as_csv=csv or False
|
as_csv=csv or False
|
||||||
)
|
)
|
||||||
|
|||||||
@ -90,6 +90,8 @@ class PlayerService(BaseService):
|
|||||||
name: Optional[str] = None,
|
name: Optional[str] = None,
|
||||||
is_injured: Optional[bool] = None,
|
is_injured: Optional[bool] = None,
|
||||||
sort: Optional[str] = None,
|
sort: Optional[str] = None,
|
||||||
|
limit: Optional[int] = None,
|
||||||
|
offset: Optional[int] = None,
|
||||||
short_output: bool = False,
|
short_output: bool = False,
|
||||||
as_csv: bool = False,
|
as_csv: bool = False,
|
||||||
) -> Dict[str, Any]:
|
) -> Dict[str, Any]:
|
||||||
@ -104,6 +106,8 @@ class PlayerService(BaseService):
|
|||||||
name: Filter by name (exact match)
|
name: Filter by name (exact match)
|
||||||
is_injured: Filter by injury status
|
is_injured: Filter by injury status
|
||||||
sort: Sort order
|
sort: Sort order
|
||||||
|
limit: Maximum number of results to return
|
||||||
|
offset: Number of results to skip for pagination
|
||||||
short_output: Exclude related data
|
short_output: Exclude related data
|
||||||
as_csv: Return as CSV format
|
as_csv: Return as CSV format
|
||||||
|
|
||||||
@ -134,11 +138,24 @@ class PlayerService(BaseService):
|
|||||||
# Convert to list of dicts
|
# Convert to list of dicts
|
||||||
players_data = cls._query_to_player_dicts(query, short_output)
|
players_data = cls._query_to_player_dicts(query, short_output)
|
||||||
|
|
||||||
|
# Store total count before pagination
|
||||||
|
total_count = len(players_data)
|
||||||
|
|
||||||
|
# Apply pagination (offset and limit)
|
||||||
|
if offset is not None:
|
||||||
|
players_data = players_data[offset:]
|
||||||
|
if limit is not None:
|
||||||
|
players_data = players_data[:limit]
|
||||||
|
|
||||||
# Return format
|
# Return format
|
||||||
if as_csv:
|
if as_csv:
|
||||||
return cls._format_player_csv(players_data)
|
return cls._format_player_csv(players_data)
|
||||||
else:
|
else:
|
||||||
return {"count": len(players_data), "players": players_data}
|
return {
|
||||||
|
"count": len(players_data),
|
||||||
|
"total": total_count,
|
||||||
|
"players": players_data
|
||||||
|
}
|
||||||
|
|
||||||
except Exception as e:
|
except Exception as e:
|
||||||
logger.error(f"Error fetching players: {e}")
|
logger.error(f"Error fetching players: {e}")
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user