--- id: 8cbb7238-1100-438f-81bd-4c31d2fae573 type: solution title: "Crit threshold Active Effects fix" tags: [vagabond-rpg, foundryvtt, active-effects, fix] importance: 0.6 confidence: 0.8 created: "2025-12-14T02:34:46.635026+00:00" updated: "2025-12-14T02:34:46.635026+00:00" --- Fixed double effect application in Foundry v13 - createEmbeddedDocuments auto-prepares data, manual prepareData() caused effects to apply twice. Added crit threshold clamping in prepareDerivedData since schema min/max constraints don't apply to effect-modified data. Tests verify skill and attack crit thresholds work with Active Effects.