---
id: bf1e80d7-cec9-4853-85a4-260f2fe3e0eb
type: workflow
title: "PR review: paper-dynasty-database#42 — remove duplicate ranking_max filter"
tags: [pr-reviewer, paper-dynasty-database, fastapi, peewee, python, duplicate-code]
importance: 0.4
confidence: 0.8
created: "2026-03-03T22:17:25.193256+00:00"
updated: "2026-03-03T22:17:25.595134+00:00"
relations:
  - target: 04e57a23-0a20-49d6-8c5a-2fa5fc4e55b5
    type: RELATED_TO
    direction: outgoing
    strength: 0.79
    edge_id: 3561b670-7afa-4a12-8131-5b099f890db5
  - target: d36a86f0-8183-4c94-8d63-0be65d3fd63a
    type: RELATED_TO
    direction: outgoing
    strength: 0.77
    edge_id: 2276edb6-002f-4656-8ff2-897a026d813c
  - target: 5ae1bf6e-1e1c-4486-8a4d-10afd9e42189
    type: RELATED_TO
    direction: outgoing
    strength: 0.77
    edge_id: 4b330e3c-087d-41e8-8ffc-3b53f004f551
---

## PR #42: fix: remove duplicate ranking_max filter in get_teams

**Verdict**: APPROVED (posted as COMMENT — Gitea blocks self-approval)

**Files reviewed**: `app/routers_v2/teams.py`

**Change**: Removed 3 lines — a duplicate `if ranking_max is not None: all_teams = all_teams.where(Team.ranking <= ranking_max)` block at old lines 141–143, identical to the block at lines 138–140.

**Analysis**: The duplicate was a no-op copy-paste. Peewee would have generated `WHERE ranking <= $1 AND ranking <= $1` — valid but redundant SQL. Removal has zero functional impact.

**Issues found**: None. Correctness, security, and conventions all clear.

**Note**: PR from `ai/paper-dynasty-database#21` branch (agent-created). Gitea API returns "approve your own pull is not allowed" when authenticated user is the PR author — used COMMENT state as fallback.