store: PR review: paper-dynasty-database#32 — remove debug print(req.scope)
This commit is contained in:
parent
0d8d1fcd54
commit
e4462ad626
@ -0,0 +1,31 @@
|
|||||||
|
---
|
||||||
|
id: c29e169a-896c-4b80-9b69-22c2880d61d7
|
||||||
|
type: workflow
|
||||||
|
title: "PR review: paper-dynasty-database#32 — remove debug print(req.scope)"
|
||||||
|
tags: [pr-reviewer, paper-dynasty-database, fastapi, python, debug-cleanup]
|
||||||
|
importance: 0.4
|
||||||
|
confidence: 0.8
|
||||||
|
created: "2026-03-03T05:03:15.987587+00:00"
|
||||||
|
updated: "2026-03-03T05:03:15.987587+00:00"
|
||||||
|
---
|
||||||
|
|
||||||
|
## PR Review: paper-dynasty-database#32
|
||||||
|
|
||||||
|
**Verdict**: APPROVED (posted as COMMENT due to Gitea self-approval restriction)
|
||||||
|
|
||||||
|
**PR**: Remove debug `print(req.scope)` from `get_docs` route in `app/main.py`
|
||||||
|
**Author**: cal
|
||||||
|
**Closes**: #31
|
||||||
|
|
||||||
|
### Files Reviewed
|
||||||
|
- `app/main.py`
|
||||||
|
|
||||||
|
### Key Findings
|
||||||
|
- Functional change: removal of `print(req.scope)` debug statement that fired on every `/api/docs` load
|
||||||
|
- Linter reformatting included (single→double quotes, trailing commas, expanded imports) — cosmetic only
|
||||||
|
- Minor security improvement: ASGI scope can contain Authorization headers; removing the print prevents accidental token logging to stdout/Docker logs
|
||||||
|
- No logic changes, no new imports, no test impact
|
||||||
|
|
||||||
|
### Notes
|
||||||
|
- Gitea does not allow self-approval; review posted as COMMENT state with APPROVED verdict in body
|
||||||
|
- Pre-existing issue noted (not flagged): `f"0.1.1"` f-string with no interpolation in `openapi()`
|
||||||
Loading…
Reference in New Issue
Block a user