store: PR review: paper-dynasty-database#47 — HTTPException 200 fix with undisclosed reformatting

graph/workflows/pr-review-paper-dynasty-database47-httpexception-200-fix-wit-759c8f.md

@@ -0,0 +1,37 @@
+---
+id: 759c8f57-2519-4e21-afd6-bf89386aedb8
+type: workflow
+title: "PR review: paper-dynasty-database#47 — HTTPException 200 fix with undisclosed reformatting"
+tags: [pr-reviewer, paper-dynasty-database, fastapi, python, scope-creep, ai-branch]
+importance: 0.6
+confidence: 0.8
+created: "2026-03-04T00:49:28.716137+00:00"
+updated: "2026-03-04T00:49:28.716137+00:00"
+---
+
+## Review Summary
+
+**PR**: paper-dynasty-database#47 — "fix: replace raise HTTPException(status_code=200) with return statements (#16)"
+**Branch**: ai/paper-dynasty-database#16 → next-release
+**Verdict**: REQUEST_CHANGES (review could not be posted — Gitea rejects self-review)
+
+## Key Findings
+
+### Core fix: Correct
+- 22 `raise HTTPException(status_code=200, detail=...)` → `return {"message": ...}` replacements across 16 router files
+- Semantically correct; HTTPException is for errors, not 200 success
+- None of the affected endpoints have response_model annotations that conflict with the new return shape
+
+### Problem: Undisclosed scope creep
+The diff is ~10x larger than described (1374 added vs 776 removed lines):
+- **Quote style**: Single → double quotes throughout all 16 files
+- **Function reformatting**: Params to one-per-line with trailing commas
+- **APIRouter/logging.basicConfig** reformatting
+
+These changes are individually safe but make confident review impossible for an AI-generated PR.
+
+## Pattern to Watch
+AI issue-worker (ai/ branches) tends to apply auto-formatter on touched files, producing massive undisclosed style diffs. This is a recurring concern. PRs should be regenerated with only targeted changes when this occurs.
+
+## Note on Review Posting
+Gitea error: "reject your own pull is not allowed" — PR author is `cal`, same as reviewer identity. Cannot post formal review on self-authored PRs.