cal/claude-memory
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

store: PR review: paper-dynasty-database#44 — batch-fetch PitchingCardRatings N+1 fix

Browse Source
This commit is contained in:
Cal Corum 2026-03-03 17:17:50 -06:00
parent 80306eb133
commit ca542f3465
1 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
graph/workflows/pr-review-paper-dynasty-database44-batch-fetch-pitchingcardr-a99673.md Normal file
View File

@ -0,0 +1,26 @@
---
id: a99673ab-2ded-48c5-9563-30df7bf4a465
type: workflow
title: "PR review: paper-dynasty-database#44 — batch-fetch PitchingCardRatings N+1 fix"
tags: [pr-reviewer, paper-dynasty-database, python, peewee, pandas, performance, n+1-queries, fix]
importance: 0.4
confidence: 0.8
created: "2026-03-03T23:17:50.809941+00:00"
updated: "2026-03-03T23:17:50.809941+00:00"
---
## PR #44 Review: batch-fetch PitchingCardRatings instead of per-row queries
**Verdict**: APPROVED (posted as COMMENT — Gitea blocks self-approval)
**Files reviewed**: `app/routers_v2/teams.py`
**What changed**: Replaced 2N per-row `PitchingCardRatings.get_or_none()` calls with a single batch `SELECT ... WHERE pitchingcard_id IN (...)` upfront. A `ratings_map` dict keyed by `(pitchingcard_id, vs_hand)` is built once; `get_total_ops` closure does O(1) dict lookups. Applied to both `sort_pitchers()` and `sort_starters()` (inside `get_team_sp`).
**Key findings**:
- Implementation is correct — key alignment between batch fetch and lookups verified
- Empty input edge case safe — existing `return None` guard fires before batch fetch
- Pre-existing bug: `vlval`/`vrval` can be None → AttributeError on `.obp`/`.slg`; unchanged by this PR
- No security issues — Peewee `<<` uses parameterized IN clause
**Note**: Gitea does not allow approving your own PRs. Review posted as COMMENT state instead of APPROVED.