diff --git a/graph/edges/pr-review-paper-dynasty-databa--RELATED_TO--pr-review-paper-dynasty-databa-8668a1.md b/graph/edges/pr-review-paper-dynasty-databa--RELATED_TO--pr-review-paper-dynasty-databa-8668a1.md new file mode 100644 index 00000000000..268d728ee58 --- /dev/null +++ b/graph/edges/pr-review-paper-dynasty-databa--RELATED_TO--pr-review-paper-dynasty-databa-8668a1.md @@ -0,0 +1,13 @@ +--- +id: 8668a1bd-c71f-44f4-b15a-34ad97917e66 +type: RELATED_TO +from_id: 37cca1c8-7fbd-43c3-a289-129b1c530f9f +from_title: "PR review: paper-dynasty-database#48 — replace broad except Exception with DoesNotExist (APPROVED)" +to_id: 759c8f57-2519-4e21-afd6-bf89386aedb8 +to_title: "PR review: paper-dynasty-database#47 — HTTPException 200 fix with undisclosed reformatting" +strength: 0.76 +created: "2026-03-04T01:18:04.616819+00:00" +updated: "2026-03-04T01:18:04.616819+00:00" +--- + +Auto-edge: PR review: paper-dynasty-database#48 — replace broad except Exception with DoesNotExist (APPROVED) → PR review: paper-dynasty-database#47 — HTTPException 200 fix with undisclosed reformatting diff --git a/graph/edges/pr-review-paper-dynasty-databa--RELATED_TO--pr-review-paper-dynasty-databa-ba47c3.md b/graph/edges/pr-review-paper-dynasty-databa--RELATED_TO--pr-review-paper-dynasty-databa-ba47c3.md new file mode 100644 index 00000000000..cbb72a5d1bf --- /dev/null +++ b/graph/edges/pr-review-paper-dynasty-databa--RELATED_TO--pr-review-paper-dynasty-databa-ba47c3.md @@ -0,0 +1,13 @@ +--- +id: ba47c3f8-ca13-47ca-98a5-2e3f6da75899 +type: RELATED_TO +from_id: 37cca1c8-7fbd-43c3-a289-129b1c530f9f +from_title: "PR review: paper-dynasty-database#48 — replace broad except Exception with DoesNotExist (APPROVED)" +to_id: 5ae1bf6e-1e1c-4486-8a4d-10afd9e42189 +to_title: "PR review: paper-dynasty-database#33 (APPROVED)" +strength: 0.81 +created: "2026-03-04T01:18:04.686668+00:00" +updated: "2026-03-04T01:18:04.686668+00:00" +--- + +Auto-edge: PR review: paper-dynasty-database#48 — replace broad except Exception with DoesNotExist (APPROVED) → PR review: paper-dynasty-database#33 (APPROVED) diff --git a/graph/edges/pr-review-paper-dynasty-databa--RELATED_TO--pr-review-paper-dynasty-databa-faef12.md b/graph/edges/pr-review-paper-dynasty-databa--RELATED_TO--pr-review-paper-dynasty-databa-faef12.md new file mode 100644 index 00000000000..745a293cbdb --- /dev/null +++ b/graph/edges/pr-review-paper-dynasty-databa--RELATED_TO--pr-review-paper-dynasty-databa-faef12.md @@ -0,0 +1,13 @@ +--- +id: faef1278-c663-4607-b2a1-4b3f8d877d99 +type: RELATED_TO +from_id: 37cca1c8-7fbd-43c3-a289-129b1c530f9f +from_title: "PR review: paper-dynasty-database#48 — replace broad except Exception with DoesNotExist (APPROVED)" +to_id: d36a86f0-8183-4c94-8d63-0be65d3fd63a +to_title: "PR review: paper-dynasty-database#33 (APPROVED)" +strength: 0.81 +created: "2026-03-04T01:18:04.655902+00:00" +updated: "2026-03-04T01:18:04.655902+00:00" +--- + +Auto-edge: PR review: paper-dynasty-database#48 — replace broad except Exception with DoesNotExist (APPROVED) → PR review: paper-dynasty-database#33 (APPROVED) diff --git a/graph/workflows/pr-review-paper-dynasty-database33-approved-5ae1bf.md b/graph/workflows/pr-review-paper-dynasty-database33-approved-5ae1bf.md index 512d4bb558a..984c100dd4e 100644 --- a/graph/workflows/pr-review-paper-dynasty-database33-approved-5ae1bf.md +++ b/graph/workflows/pr-review-paper-dynasty-database33-approved-5ae1bf.md @@ -6,7 +6,7 @@ tags: [pr-reviewer, paper-dynasty-database, automation] importance: 0.5 confidence: 0.8 created: "2026-03-03T18:09:25.812471+00:00" -updated: "2026-03-04T00:49:29.139128+00:00" +updated: "2026-03-04T01:18:04.686668+00:00" relations: - target: 530bfb6f-841c-4381-b8a4-d0b6fbc02878 type: RELATED_TO @@ -38,6 +38,11 @@ relations: direction: incoming strength: 0.81 edge_id: 2fd15bb5-01a0-4ad7-bcac-0fd3d4da87ea + - target: 37cca1c8-7fbd-43c3-a289-129b1c530f9f + type: RELATED_TO + direction: incoming + strength: 0.81 + edge_id: ba47c3f8-ca13-47ca-98a5-2e3f6da75899 --- Reviewed paper-dynasty-database PR #33 — fix: replace 467 manual db.close() calls with middleware (#30). Verdict: APPROVED. Summary: Correct implementation of the standard Peewee + FastAPI middleware pattern. 467 db.close() calls removed from 30 router files; middleware correctly uses reuse_if_open=True with try/finally and is_clos. Cost: $1.062883 diff --git a/graph/workflows/pr-review-paper-dynasty-database33-approved-d36a86.md b/graph/workflows/pr-review-paper-dynasty-database33-approved-d36a86.md index a9a6e642a9f..e23771da4b2 100644 --- a/graph/workflows/pr-review-paper-dynasty-database33-approved-d36a86.md +++ b/graph/workflows/pr-review-paper-dynasty-database33-approved-d36a86.md @@ -6,7 +6,7 @@ tags: [pr-reviewer, paper-dynasty-database, automation] importance: 0.5 confidence: 0.8 created: "2026-03-03T06:06:26.108954+00:00" -updated: "2026-03-04T00:49:29.108653+00:00" +updated: "2026-03-04T01:18:04.655902+00:00" relations: - target: 04e57a23-0a20-49d6-8c5a-2fa5fc4e55b5 type: RELATED_TO @@ -58,6 +58,11 @@ relations: direction: incoming strength: 0.81 edge_id: ad1d9792-9f19-4d2d-b143-05f27208a318 + - target: 37cca1c8-7fbd-43c3-a289-129b1c530f9f + type: RELATED_TO + direction: incoming + strength: 0.81 + edge_id: faef1278-c663-4607-b2a1-4b3f8d877d99 --- Reviewed paper-dynasty-database PR #33 — fix: replace 467 manual db.close() calls with middleware (#30). Verdict: APPROVED. Summary: Correct implementation of the standard Peewee + FastAPI middleware pattern. Eliminates connection-leak bug across 467 call sites. Safe for both SQLite (dev) and PooledPostgresqlDatabase (prod). Minor:. Cost: $0.98641425 diff --git a/graph/workflows/pr-review-paper-dynasty-database47-httpexception-200-fix-wit-759c8f.md b/graph/workflows/pr-review-paper-dynasty-database47-httpexception-200-fix-wit-759c8f.md index 4adb7dc9e22..1b8bda3a659 100644 --- a/graph/workflows/pr-review-paper-dynasty-database47-httpexception-200-fix-wit-759c8f.md +++ b/graph/workflows/pr-review-paper-dynasty-database47-httpexception-200-fix-wit-759c8f.md @@ -6,7 +6,7 @@ tags: [pr-reviewer, paper-dynasty-database, fastapi, python, scope-creep, ai-bra importance: 0.6 confidence: 0.8 created: "2026-03-04T00:49:28.716137+00:00" -updated: "2026-03-04T00:49:29.139128+00:00" +updated: "2026-03-04T01:18:04.616819+00:00" relations: - target: 1e6628fa-dc5d-4047-a9ae-ecb884e04ba2 type: RELATED_TO @@ -23,6 +23,11 @@ relations: direction: outgoing strength: 0.81 edge_id: 2fd15bb5-01a0-4ad7-bcac-0fd3d4da87ea + - target: 37cca1c8-7fbd-43c3-a289-129b1c530f9f + type: RELATED_TO + direction: incoming + strength: 0.76 + edge_id: 8668a1bd-c71f-44f4-b15a-34ad97917e66 --- ## Review Summary diff --git a/graph/workflows/pr-review-paper-dynasty-database48-replace-broad-except-exce-37cca1.md b/graph/workflows/pr-review-paper-dynasty-database48-replace-broad-except-exce-37cca1.md index 62cd4d0743e..11f9bdfa3d4 100644 --- a/graph/workflows/pr-review-paper-dynasty-database48-replace-broad-except-exce-37cca1.md +++ b/graph/workflows/pr-review-paper-dynasty-database48-replace-broad-except-exce-37cca1.md @@ -6,7 +6,23 @@ tags: [pr-reviewer, paper-dynasty-database, fastapi, peewee, python, exception-h importance: 0.4 confidence: 0.8 created: "2026-03-04T01:18:04.266886+00:00" -updated: "2026-03-04T01:18:04.266886+00:00" +updated: "2026-03-04T01:18:04.686668+00:00" +relations: + - target: 759c8f57-2519-4e21-afd6-bf89386aedb8 + type: RELATED_TO + direction: outgoing + strength: 0.76 + edge_id: 8668a1bd-c71f-44f4-b15a-34ad97917e66 + - target: d36a86f0-8183-4c94-8d63-0be65d3fd63a + type: RELATED_TO + direction: outgoing + strength: 0.81 + edge_id: faef1278-c663-4607-b2a1-4b3f8d877d99 + - target: 5ae1bf6e-1e1c-4486-8a4d-10afd9e42189 + type: RELATED_TO + direction: outgoing + strength: 0.81 + edge_id: ba47c3f8-ca13-47ca-98a5-2e3f6da75899 --- ## PR #48: fix: replace broad except Exception blocks with DoesNotExist (#15)