store: PR review: paper-dynasty-database#59 (REQUEST_CHANGES)
This commit is contained in:
parent
feda52e0dd
commit
939afa9afb
@ -0,0 +1,12 @@
|
|||||||
|
---
|
||||||
|
id: 8236b452-26b3-4287-a126-29fb046c4b0b
|
||||||
|
type: workflow
|
||||||
|
title: "PR review: paper-dynasty-database#59 (REQUEST_CHANGES)"
|
||||||
|
tags: [pr-reviewer, paper-dynasty-database, automation]
|
||||||
|
importance: 0.5
|
||||||
|
confidence: 0.8
|
||||||
|
created: "2026-03-05T03:47:43.310852+00:00"
|
||||||
|
updated: "2026-03-05T03:47:43.310852+00:00"
|
||||||
|
---
|
||||||
|
|
||||||
|
Reviewed paper-dynasty-database PR #59 — feat: add scout opportunities and claims API (#44). Verdict: REQUEST_CHANGES. Summary: Three regressions from recently merged PRs: (1) plaintext bearer token logging (#7/#8 regression, security), (2) raise HTTPException(status_code=200) in delete handlers (#47 regression), (3) except Exception instead of peewee.DoesNotExist (#48 regression). Also: unused import of ScoutOpportunity in scout_claims.py, and Peewee FK on_delete missing for opener_team vs SQL migration. Domain model and API design are otherwise solid.. Cost: $0.5874949999999999
|
||||||
Loading…
Reference in New Issue
Block a user