cal/claude-memory
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

store: Break circular imports by extracting shared models to models.py

Browse Source
This commit is contained in:
Cal Corum 2026-02-25 16:44:18 -06:00
parent 180856dee2
commit 8d36043c04
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
graph/solutions/break-circular-imports-by-extracting-shared-models-to-models-b235f9.md Normal file
View File

@ -0,0 +1,12 @@
---
id: b235f924-b532-40cd-be39-4fb765938add
type: solution
title: "Break circular imports by extracting shared models to models.py"
tags: [python, circular-imports, architecture, refactoring, paper-dynasty]
importance: 0.8
confidence: 0.8
created: "2026-02-25T22:44:18.326495+00:00"
updated: "2026-02-25T22:44:18.326495+00:00"
---
## Problem\nTwo modules mutually importing from each other (A imports from B, B imports from A) creates circular import errors.\n\n## Solution\nExtract the shared types/classes into a third dedicated `models.py`. Both A and B then import from `models.py`, breaking the cycle.\n\n## Applied In\npaper-dynasty/card-creation (feature/fullcard-migration branch):\n- `batters/calcs_batter.py` and `batters/card_builder.py` both needed `BattingCardRatingsModel`\n- Extracted it to `batters/models.py`\n- Same pattern applied for `pitchers/models.py`\n\n## Result\n- Eliminates lazy/function-body imports (which are an anti-pattern workaround)\n- Clean module-level imports throughout\n- No circular dependency