cal/claude-memory
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

store: PR review: paper-dynasty-database#33 (APPROVED)

Browse Source
This commit is contained in:
Cal Corum 2026-03-03 12:08:58 -06:00
parent b7a3ca293f
commit 87afc4f3c4
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
graph/workflows/pr-review-paper-dynasty-database33-approved-04e57a.md Normal file
View File

@ -0,0 +1,23 @@
---
id: 04e57a23-0a20-49d6-8c5a-2fa5fc4e55b5
type: workflow
title: "PR review: paper-dynasty-database#33 (APPROVED)"
tags: [pr-reviewer, paper-dynasty-database, fastapi, peewee, middleware, python]
importance: 0.5
confidence: 0.8
created: "2026-03-03T18:08:58.224854+00:00"
updated: "2026-03-03T18:08:58.224854+00:00"
---
Reviewed paper-dynasty-database PR #33 — fix: replace 467 manual db.close() calls with middleware (#30). Verdict: APPROVED.
**Summary:** Correct implementation of the standard Peewee + FastAPI middleware pattern. Eliminates connection-leak bug across 467 call sites. Safe for both SQLite (dev) and PooledPostgresqlDatabase (prod).
**Key findings:**
- Middleware uses `reuse_if_open=True` and `is_closed()` guard — correct
- Diff: exactly 467 db.close() removals, 0 other router logic changes
- 15 router files will have unused `db` imports post-merge (flagged for follow-up)
- Middleware placement after include_router() is valid in Starlette
- Gitea blocks self-approval; posted as COMMENT with APPROVED recommendation
**Files changed:** app/main.py + 30 routers_v2 files