diff --git a/graph/fixes/fix-remove-duplicate-ranking-max-filter-in-paper-dynasty-dat-4b8f44.md b/graph/fixes/fix-remove-duplicate-ranking-max-filter-in-paper-dynasty-dat-4b8f44.md new file mode 100644 index 00000000000..721ecb545b1 --- /dev/null +++ b/graph/fixes/fix-remove-duplicate-ranking-max-filter-in-paper-dynasty-dat-4b8f44.md @@ -0,0 +1,25 @@ +--- +id: 4b8f4439-f46b-49c3-975d-6965a0aa97f3 +type: fix +title: "Fix: Remove duplicate ranking_max filter in paper-dynasty-database get_teams" +tags: [paper-dynasty, paper-dynasty-database, python, fastapi, bug, teams, filter] +importance: 0.5 +confidence: 0.8 +created: "2026-03-03T22:02:24.963367+00:00" +updated: "2026-03-03T22:02:24.963367+00:00" +--- + +## Problem +`app/routers_v2/teams.py:141-143` had a duplicate `if ranking_max is not None` filter block — a copy-paste no-op of the filter already applied at lines 138-140. + +## Root Cause +Copy-paste error when adding the `ranking_min` filter. The developer likely duplicated the `ranking_max` block and forgot to change it to `ranking_min`. + +## Solution +Removed the 3-line duplicate block (lines 141-143). The first `ranking_max` filter at lines 138-140 was correct and sufficient. + +## Files Changed +- `app/routers_v2/teams.py` + +## PR +https://git.manticorum.com/cal/paper-dynasty-database/pulls/42 (issue #21)