store: PR review: paper-dynasty-database#49 — document SQLite synchronous=0 pragma

graph/workflows/pr-review-paper-dynasty-database49-document-sqlite-synchrono-43b222.md

@@ -0,0 +1,28 @@
+---
+id: 43b222b2-abef-4ae0-8d3f-45c7a588eaa7
+type: workflow
+title: "PR review: paper-dynasty-database#49 — document SQLite synchronous=0 pragma"
+tags: [pr-reviewer, paper-dynasty-database, sqlite, db-engine, documentation, pragma]
+importance: 0.4
+confidence: 0.8
+created: "2026-03-04T01:48:01.581634+00:00"
+updated: "2026-03-04T01:48:01.581634+00:00"
+---
+
+## PR Review: paper-dynasty-database#49
+
+**Verdict:** APPROVED (posted as COMMENT — Gitea blocks self-approval)
+
+**Files reviewed:** `app/db_engine.py`
+
+**Changes:**
+1. Added block comment above the SQLite `pragmas` dict documenting `synchronous=0` (crash-corruption risk, WAL mitigation, dev-only scope). Technically accurate.
+2. Undocumented second hunk: reformatted `db.create_tables([...])` at line 933 to multi-line with trailing comma — cosmetic only.
+
+**Key findings:**
+- Documentation-only PR, no functional changes.
+- Comment is correct and proportionate.
+- PR body omitted the second formatting hunk — minor omission, flagged in review as suggestion.
+- Gitea error "approve your own pull is not allowed" — fell back to COMMENT state.
+
+**Note:** `synchronous=0` is intentionally dev-only; production uses PostgreSQL via `DATABASE_TYPE` env var.