store: pd-cards retrosheet --season-pct defaults to 1.0, overrides retrosheet_data.py config
This commit is contained in:
parent
fc4aad8008
commit
17c402c68f
@ -0,0 +1,43 @@
|
|||||||
|
---
|
||||||
|
id: ff4f4ac5-dfe9-4ee7-b336-0f082bac95fd
|
||||||
|
type: fix
|
||||||
|
title: "pd-cards retrosheet --season-pct defaults to 1.0, overrides retrosheet_data.py config"
|
||||||
|
tags: [paper-dynasty, cli, pd-cards, retrosheet, gotcha, fix]
|
||||||
|
importance: 0.8
|
||||||
|
confidence: 0.8
|
||||||
|
created: "2026-02-22T18:14:11.078445+00:00"
|
||||||
|
updated: "2026-02-22T18:14:11.078445+00:00"
|
||||||
|
---
|
||||||
|
|
||||||
|
# Bug: pd-cards retrosheet --season-pct Ignores Script Config
|
||||||
|
|
||||||
|
## Problem
|
||||||
|
|
||||||
|
The `pd-cards retrosheet process` command defaults `--season-pct` to `1.0`. In `pd_cards/commands/retrosheet.py` line 108:
|
||||||
|
|
||||||
|
```python
|
||||||
|
rd.SEASON_PCT = season_pct
|
||||||
|
```
|
||||||
|
|
||||||
|
This unconditionally overwrites whatever `SEASON_PCT` is set to in `retrosheet_data.py`. If you don't pass `--season-pct` on the CLI, the script's value is silently replaced with `1.0`.
|
||||||
|
|
||||||
|
## Symptom
|
||||||
|
|
||||||
|
Dry run output showed `Season %: 100%` even though `retrosheet_data.py` had a lower value configured. This revealed the issue.
|
||||||
|
|
||||||
|
## Fix / Workaround
|
||||||
|
|
||||||
|
Always pass `--season-pct` explicitly on the command line for PotM runs:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
# July PotM: 31 games / 162 season
|
||||||
|
pd-cards retrosheet process 2005 --cardset-id 28 --description "July PotM" --season-pct 0.191 --dry-run
|
||||||
|
```
|
||||||
|
|
||||||
|
## File Reference
|
||||||
|
|
||||||
|
`pd_cards/commands/retrosheet.py`, line 27 (default) and line 108 (override).
|
||||||
|
|
||||||
|
## Impact
|
||||||
|
|
||||||
|
PotM cards would get inflated stats if run at 100% season when they should reflect a partial month of play.
|
||||||
Loading…
Reference in New Issue
Block a user