From 022f5deeb7cdee43add0ded75437d460aa7a437b Mon Sep 17 00:00:00 2001 From: Cal Corum Date: Tue, 3 Mar 2026 13:03:04 -0600 Subject: [PATCH] =?UTF-8?q?store:=20PR=20review:=20paper-dynasty-discord#4?= =?UTF-8?q?3=20=E2=80=94=20explicit=20.gitignore=20for=20service-creds.jso?= =?UTF-8?q?n?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- ...ord43-explicit-gitignore-for-ser-d71493.md | 28 +++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 graph/workflows/pr-review-paper-dynasty-discord43-explicit-gitignore-for-ser-d71493.md diff --git a/graph/workflows/pr-review-paper-dynasty-discord43-explicit-gitignore-for-ser-d71493.md b/graph/workflows/pr-review-paper-dynasty-discord43-explicit-gitignore-for-ser-d71493.md new file mode 100644 index 00000000000..b008e192915 --- /dev/null +++ b/graph/workflows/pr-review-paper-dynasty-discord43-explicit-gitignore-for-ser-d71493.md @@ -0,0 +1,28 @@ +--- +id: d714936b-855b-46f0-ad85-c8bb55f743ad +type: workflow +title: "PR review: paper-dynasty-discord#43 — explicit .gitignore for service-creds.json" +tags: [pr-reviewer, paper-dynasty-discord, gitignore, security, credentials] +importance: 0.4 +confidence: 0.8 +created: "2026-03-03T19:03:04.484112+00:00" +updated: "2026-03-03T19:03:04.484112+00:00" +--- + +## PR Review: paper-dynasty-discord#43 + +**Verdict**: APPROVED (posted as COMMENT due to Gitea self-approval restriction) + +**PR Title**: fix: add explicit .gitignore entry for service-creds.json (#40) + +**Files Reviewed**: `.gitignore` + +**Summary**: Single-line addition of `storage/paper-dynasty-service-creds.json` to `.gitignore`. The existing `storage*` wildcard already covers the file, making this technically redundant. However, the explicit entry is justified as defense-in-depth for a sensitive Google Sheets service credential file referenced in `cogs/gameplay.py:120`. + +**Key Findings**: +- Redundant but intentional — `storage*` already ignores the entire `storage/` directory +- No ordering issues or negation rules that could cause conflicts +- Positive security posture: protects against accidental exposure if `storage*` is ever removed +- Clean, minimal change following existing "Project specifics" block convention + +**Note**: Gitea blocks self-approval (`approve your own pull is not allowed`), so APPROVED verdict was posted as a COMMENT review instead.